From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53705C2F421 for ; Mon, 21 Jan 2019 16:34:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A4792089F for ; Mon, 21 Jan 2019 16:34:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B6ge+QNA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730549AbfAUQd6 (ORCPT ); Mon, 21 Jan 2019 11:33:58 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:44468 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729940AbfAUQd6 (ORCPT ); Mon, 21 Jan 2019 11:33:58 -0500 Received: by mail-pl1-f195.google.com with SMTP id e11so10059590plt.11 for ; Mon, 21 Jan 2019 08:33:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ewwmRvhnQ+d+4ec24rdlfVGqzLvw7YG8N1mEnbos0p4=; b=B6ge+QNAlb/SVDnrf3h7uKw5gZflONNI9KHc9XWxmKybXLxDUwnlnHO1XqOVqLAAVV kg/5vlgNDn41mspxAMlu/wka1otKRXpmUAs5Rr9abyjbUMGISkezD65QVSL5axgnnPJO 3lrC3ifPGlXqARjlYlTWSTsslzPDRkococNrbHOufISyElPO9xVFSMh5Uvm3Pue+mCfx DDBS0fZNr0iAwsVfe3flRiUMst5pWfaZDgl1ELE97UI3ILT/rVsl+QppusKmzP8Dhr8/ xu9jxzPAfQStELkknY7Ulo4cSwaI9qOp02Ydf1IiiAHyo5kX6FPJOWWFCZLaFrvi1HJ5 aFvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ewwmRvhnQ+d+4ec24rdlfVGqzLvw7YG8N1mEnbos0p4=; b=IWPctfPHN+Dm5Z3/snyTnJWXWIDoVtVrkkNEjtWIPihgpNQqPTlWJVoWk9wMarGKk6 LK/hitfoARKaY5G7MfgaNvuDVNtP51KeL34WP//oNr70cgcO09TJ/KmljnMGWFYeKJfH FZ8ZY5SD8aVXZSPYuCVcmH+urfaTNnQ0UHD/gjXQ5fQMcwPHc/WUiKeoCKfwLWN1CMMC pZt8CouoyJshVgbvA3Sh3s0tLW0wMzQScJsxe2DVyao4iEiJRDJC4FsS+r8fUUTs+Jx9 0oU5JvgDzLy2FC32j8v1a0QNTHF/jmS44/PwriMlOr6hvPoQHkudjvvyxMTbQ6+XVxdV VSdw== X-Gm-Message-State: AJcUukerWluPZC0EgKY6hnIyWsMxPWZNL513WNmuX7OLicEIm8ydJqLl gfd+0e9RZkYBUA9ZTVO5l4E= X-Google-Smtp-Source: ALg8bN4Z1Y7gEludD0kU8jBQF7NLzOV8G+jRqNe42EKlyua+w2xQI9TaTWeZCesmTZ/87s3WitWQUQ== X-Received: by 2002:a17:902:680f:: with SMTP id h15mr30344617plk.40.1548088437814; Mon, 21 Jan 2019 08:33:57 -0800 (PST) Received: from ?IPv6:2601:282:800:fd80:d58c:9df2:49cf:9a2a? ([2601:282:800:fd80:d58c:9df2:49cf:9a2a]) by smtp.googlemail.com with ESMTPSA id s190sm17889138pfb.103.2019.01.21.08.33.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Jan 2019 08:33:56 -0800 (PST) Subject: Re: [PATCH v2 iproute2 1/1] xfrm: add option to hide keys in state output To: Benedict Wong , netdev@vger.kernel.org Cc: nharold@google.com, lorenzo@google.com, maze@google.com References: <20190118191217.131649-1-benedictwong@google.com> <20190118191217.131649-2-benedictwong@google.com> From: David Ahern Message-ID: <2ee964f2-f289-cd85-edb8-4fd6959a8543@gmail.com> Date: Mon, 21 Jan 2019 09:33:55 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190118191217.131649-2-benedictwong@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/18/19 12:12 PM, Benedict Wong wrote: > ip xfrm state show currently dumps keys unconditionally. This limits its > use in logging, as security information can be leaked. > > This patch adds a nokeys option to ip xfrm ( state show | monitor ), which > prevents the printing of keys. This allows ip xfrm state show to be used > in logging without exposing keys. > > Signed-off-by: Benedict Wong > --- > ip/ipxfrm.c | 49 +++++++++++++++++++++++++--------------------- > ip/xfrm.h | 5 +++-- > ip/xfrm_monitor.c | 7 +++++-- > ip/xfrm_state.c | 27 ++++++++++++++++++++----- > man/man8/ip-xfrm.8 | 15 +++++++++++++- > 5 files changed, 71 insertions(+), 32 deletions(-) > applied to iproute2-next. Thanks