netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Yue Haibing <yuehaibing@huawei.com>, <jesse.brandeburg@intel.com>,
	<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>
Cc: <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: e1000e: Remove unused declarations
Date: Mon, 14 Aug 2023 15:19:10 -0700	[thread overview]
Message-ID: <2ef66ad0-d8d2-ae28-9624-04a3fbe94de4@intel.com> (raw)
In-Reply-To: <20230814135821.4808-1-yuehaibing@huawei.com>

On 8/14/2023 6:58 AM, Yue Haibing wrote:
> Commit bdfe2da6aefd ("e1000e: cosmetic move of function prototypes to the new mac.h")
> declared but never implemented them.
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

I believe netdev has been taking all these unused declaration patches 
directly so...

Reviewed-by: Tony Nguyen <anthony.l.nguyen@intel.com>

> ---
>   drivers/net/ethernet/intel/e1000e/mac.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/e1000e/mac.h b/drivers/net/ethernet/intel/e1000e/mac.h
> index 6ab261119801..563176fd436e 100644
> --- a/drivers/net/ethernet/intel/e1000e/mac.h
> +++ b/drivers/net/ethernet/intel/e1000e/mac.h
> @@ -29,8 +29,6 @@ s32 e1000e_set_fc_watermarks(struct e1000_hw *hw);
>   s32 e1000e_setup_fiber_serdes_link(struct e1000_hw *hw);
>   s32 e1000e_setup_led_generic(struct e1000_hw *hw);
>   s32 e1000e_setup_link_generic(struct e1000_hw *hw);
> -s32 e1000e_validate_mdi_setting_generic(struct e1000_hw *hw);
> -s32 e1000e_validate_mdi_setting_crossover_generic(struct e1000_hw *hw);
>   
>   void e1000e_clear_hw_cntrs_base(struct e1000_hw *hw);
>   void e1000_clear_vfta_generic(struct e1000_hw *hw);

  reply	other threads:[~2023-08-14 22:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-14 13:58 [PATCH net-next] net: e1000e: Remove unused declarations Yue Haibing
2023-08-14 22:19 ` Tony Nguyen [this message]
2023-08-16  2:06   ` Jakub Kicinski
2023-08-16  2:10 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ef66ad0-d8d2-ae28-9624-04a3fbe94de4@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).