* [PATCH net-next] net: e1000e: Remove unused declarations
@ 2023-08-14 13:58 Yue Haibing
2023-08-14 22:19 ` Tony Nguyen
2023-08-16 2:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Yue Haibing @ 2023-08-14 13:58 UTC (permalink / raw)
To: jesse.brandeburg, anthony.l.nguyen, davem, edumazet, kuba, pabeni,
yuehaibing
Cc: intel-wired-lan, netdev
Commit bdfe2da6aefd ("e1000e: cosmetic move of function prototypes to the new mac.h")
declared but never implemented them.
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/intel/e1000e/mac.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/e1000e/mac.h b/drivers/net/ethernet/intel/e1000e/mac.h
index 6ab261119801..563176fd436e 100644
--- a/drivers/net/ethernet/intel/e1000e/mac.h
+++ b/drivers/net/ethernet/intel/e1000e/mac.h
@@ -29,8 +29,6 @@ s32 e1000e_set_fc_watermarks(struct e1000_hw *hw);
s32 e1000e_setup_fiber_serdes_link(struct e1000_hw *hw);
s32 e1000e_setup_led_generic(struct e1000_hw *hw);
s32 e1000e_setup_link_generic(struct e1000_hw *hw);
-s32 e1000e_validate_mdi_setting_generic(struct e1000_hw *hw);
-s32 e1000e_validate_mdi_setting_crossover_generic(struct e1000_hw *hw);
void e1000e_clear_hw_cntrs_base(struct e1000_hw *hw);
void e1000_clear_vfta_generic(struct e1000_hw *hw);
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net: e1000e: Remove unused declarations
2023-08-14 13:58 [PATCH net-next] net: e1000e: Remove unused declarations Yue Haibing
@ 2023-08-14 22:19 ` Tony Nguyen
2023-08-16 2:06 ` Jakub Kicinski
2023-08-16 2:10 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Tony Nguyen @ 2023-08-14 22:19 UTC (permalink / raw)
To: Yue Haibing, jesse.brandeburg, davem, edumazet, kuba, pabeni
Cc: intel-wired-lan, netdev
On 8/14/2023 6:58 AM, Yue Haibing wrote:
> Commit bdfe2da6aefd ("e1000e: cosmetic move of function prototypes to the new mac.h")
> declared but never implemented them.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
I believe netdev has been taking all these unused declaration patches
directly so...
Reviewed-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> ---
> drivers/net/ethernet/intel/e1000e/mac.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/e1000e/mac.h b/drivers/net/ethernet/intel/e1000e/mac.h
> index 6ab261119801..563176fd436e 100644
> --- a/drivers/net/ethernet/intel/e1000e/mac.h
> +++ b/drivers/net/ethernet/intel/e1000e/mac.h
> @@ -29,8 +29,6 @@ s32 e1000e_set_fc_watermarks(struct e1000_hw *hw);
> s32 e1000e_setup_fiber_serdes_link(struct e1000_hw *hw);
> s32 e1000e_setup_led_generic(struct e1000_hw *hw);
> s32 e1000e_setup_link_generic(struct e1000_hw *hw);
> -s32 e1000e_validate_mdi_setting_generic(struct e1000_hw *hw);
> -s32 e1000e_validate_mdi_setting_crossover_generic(struct e1000_hw *hw);
>
> void e1000e_clear_hw_cntrs_base(struct e1000_hw *hw);
> void e1000_clear_vfta_generic(struct e1000_hw *hw);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net: e1000e: Remove unused declarations
2023-08-14 22:19 ` Tony Nguyen
@ 2023-08-16 2:06 ` Jakub Kicinski
0 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2023-08-16 2:06 UTC (permalink / raw)
To: Tony Nguyen
Cc: Yue Haibing, jesse.brandeburg, davem, edumazet, pabeni,
intel-wired-lan, netdev
On Mon, 14 Aug 2023 15:19:10 -0700 Tony Nguyen wrote:
> On 8/14/2023 6:58 AM, Yue Haibing wrote:
> > Commit bdfe2da6aefd ("e1000e: cosmetic move of function prototypes to the new mac.h")
> > declared but never implemented them.
> >
> > Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
>
> I believe netdev has been taking all these unused declaration patches
> directly so...
>
> Reviewed-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Thanks! We do have a bit of a mixed record either applying these
or deferring to maintainers...
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: e1000e: Remove unused declarations
2023-08-14 13:58 [PATCH net-next] net: e1000e: Remove unused declarations Yue Haibing
2023-08-14 22:19 ` Tony Nguyen
@ 2023-08-16 2:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-08-16 2:10 UTC (permalink / raw)
To: Yue Haibing
Cc: jesse.brandeburg, anthony.l.nguyen, davem, edumazet, kuba, pabeni,
intel-wired-lan, netdev
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 14 Aug 2023 21:58:21 +0800 you wrote:
> Commit bdfe2da6aefd ("e1000e: cosmetic move of function prototypes to the new mac.h")
> declared but never implemented them.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> drivers/net/ethernet/intel/e1000e/mac.h | 2 --
> 1 file changed, 2 deletions(-)
Here is the summary with links:
- [net-next] net: e1000e: Remove unused declarations
https://git.kernel.org/netdev/net-next/c/3bfdcc324a04
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-16 2:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-14 13:58 [PATCH net-next] net: e1000e: Remove unused declarations Yue Haibing
2023-08-14 22:19 ` Tony Nguyen
2023-08-16 2:06 ` Jakub Kicinski
2023-08-16 2:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).