From: Andrew Lunn <andrew@lunn.ch>
To: Mohsin Bashir <mohsin.bashr@gmail.com>
Cc: Maxime Chevallier <maxime.chevallier@bootlin.com>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
pabeni@redhat.com, shuah@kernel.org
Subject: Re: [PATCH net] selftests: drv-net: pause: Skip support tests without link autonegotiation
Date: Fri, 30 Oct 2026 21:12:38 +0100 [thread overview]
Message-ID: <2efe9f61-5a04-473e-bb57-12d2779ad829@lunn.ch> (raw)
In-Reply-To: <7cd99851-5bc0-4db8-a44c-a664c3f824b1@gmail.com>
> > Or maybe a bit more clever, have a quick check to see if the device accepts
> > an ethtool -s XXX command ? looks like fbnic will refuse all of'em as it
> > doesn't have a .set_link_ksettings.
> >
>
> Yes, checking whether the DUT accepts ethtool -s is one options. We could
> reuse the existing autonegotiated and forced-link attempts, and report SKIP
> if neither allows pause checks to run. Alternatively, we can add a remote
> arg to require_link_autoneg(), default to True, and pass False for this test
> so it checks only the DUT’s autonegotiation support.
There is a subset of pause configurations which don't require autoneg.
ethtool --pause eth42 autoneg off [rx on|off] [tx on|off]
These can be implemented by a device which does not support
autoneg. These setting go straight to the MAC. They are never
negotiated.
Andrew
prev parent reply other threads:[~2026-10-30 20:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 17:35 [PATCH net] selftests: drv-net: pause: Skip support tests without link autonegotiation Mohsin Bashir
2026-10-30 17:54 ` Maxime Chevallier
2026-10-30 18:39 ` Mohsin Bashir
2026-10-30 20:12 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2efe9f61-5a04-473e-bb57-12d2779ad829@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox