From: Paolo Abeni <pabeni@redhat.com>
To: Erni Sri Satya Vennela <ernis@linux.microsoft.com>,
Erni Sri Satya Vennela <ernis@microsoft.com>,
kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, longli@microsoft.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
dipayanroy@linux.microsoft.com, ssengar@linux.microsoft.com,
shradhagupta@linux.microsoft.com, shirazsaleem@microsoft.com,
gargaditya@linux.microsoft.com, linux-hyperv@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3] net: mana: Add MAC address to vPort logs and clarify error messages
Date: Tue, 24 Feb 2026 13:22:58 +0100 [thread overview]
Message-ID: <2f11ece1-cb85-4491-89d5-c8818666ff41@redhat.com> (raw)
In-Reply-To: <20260223040826.750864-1-ernis@linux.microsoft.com>
On 2/23/26 5:08 AM, Erni Sri Satya Vennela wrote:
> @@ -861,8 +862,8 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len,
> tx_wr = &txq->msg_buf->reqs[msg_id];
>
> if (req_len > tx_wr->buf_len) {
> - dev_err(hwc->dev, "HWC: req msg size: %d > %d\n", req_len,
> - tx_wr->buf_len);
> + dev_err(hwc->dev, "%s:%d: req msg size: %d > %d\n",
> + __func__, __LINE__, req_len, tx_wr->buf_len);
I fail to see any relevant information added here ...
> err = -EINVAL;
> goto out;
> }
> @@ -878,6 +879,7 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len,
> req_msg->req.hwc_msg_id = msg_id;
>
> tx_wr->msg_size = req_len;
> + command = req_msg->req.msg_type;
>
> if (gc->is_pf) {
> dest_vrq = hwc->pf_dest_vrq_id;
> @@ -886,15 +888,16 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len,
>
> err = mana_hwc_post_tx_wqe(txq, tx_wr, dest_vrq, dest_vrcq, false);
> if (err) {
> - dev_err(hwc->dev, "HWC: Failed to post send WQE: %d\n", err);
> + dev_err(hwc->dev, "%s:%d: Failed to post send WQE: %d\n",
> + __func__, __LINE__, err);
... and here. The string message should be (and apparently is) enough to
locate the relevant code inside the tree. Please don't included
unneeded/irrelevant changes.
Thanks,
Paolo
next prev parent reply other threads:[~2026-02-24 12:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 4:08 [PATCH net-next v3] net: mana: Add MAC address to vPort logs and clarify error messages Erni Sri Satya Vennela
2026-02-24 12:22 ` Paolo Abeni [this message]
2026-02-25 17:36 ` Erni Sri Satya Vennela
-- strict thread matches above, loose matches on Subject: below --
2026-02-11 5:43 Erni Sri Satya Vennela
2026-02-11 18:42 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f11ece1-cb85-4491-89d5-c8818666ff41@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=dipayanroy@linux.microsoft.com \
--cc=edumazet@google.com \
--cc=ernis@linux.microsoft.com \
--cc=ernis@microsoft.com \
--cc=gargaditya@linux.microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=shirazsaleem@microsoft.com \
--cc=shradhagupta@linux.microsoft.com \
--cc=ssengar@linux.microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox