From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>,
Sven Van Asbroeck <thesven73@gmail.com>,
Woojung.Huh@microchip.com, Tristram.Ha@microchip.com
Cc: Sven Van Asbroeck <svendev@arcx.com>,
helmut.buchsbaum@gmail.com, Maarten.Blomme@flir.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.
Date: Tue, 6 Feb 2018 09:47:26 -0800 [thread overview]
Message-ID: <2f18b10f-1c84-f386-2b13-12163c0fd8a5@gmail.com> (raw)
In-Reply-To: <20180206170526.GK12679@lunn.ch>
On 02/06/2018 09:05 AM, Andrew Lunn wrote:
> On Tue, Feb 06, 2018 at 11:58:17AM -0500, Sven Van Asbroeck wrote:
>> On Tue, Feb 6, 2018 at 11:50 AM, Andrew Lunn <andrew@lunn.ch> wrote:
>>> And a DSA driver does not need to be complex. You can start simple,
>>> and add more features later.
>>
>> I see. Would it be possible/practical to start with just phy_read/write,
>> port_enable/disable in dsa_switch_ops ? And just add a sysfs bin file
>> for userspace register access ?
>
> I would NACK sysfs bin file. Do it right, or don't do it at all.
Sven, there is a standard ethtool register dump interface that can be
used to provide register dumps, if necessary, that might fit your use case.
Aside from the phy_read/write, port_enable/disable, you will likely need
to have a get_tag_protocol() implementation returning
DSA_TAG_PROTO_NONE, and a setup() operation, other should be entirely
optional for now.
Out of curiosity, are there any break out boards with a KS8995 switch
available that we could e.g: plug to a Raspberry Pi or any similar board?
>
> I think i would first want to know what Tristam/Microchip plans
> are. Does he intend to keep on working on the patches from last year?
Yes, this would be good to keep alive, the patches look good, they just
need to get in now.
--
Florian
next prev parent reply other threads:[~2018-02-06 17:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 15:13 [PATCH v1 0/1] spi_ks8995: use regmap to access chip registers Sven Van Asbroeck
2018-02-06 15:13 ` [PATCH v1 1/1] " Sven Van Asbroeck
2018-02-08 2:49 ` David Miller
2018-02-06 16:14 ` [PATCH v1 0/1] " Andrew Lunn
2018-02-06 16:41 ` Sven Van Asbroeck
2018-02-06 16:50 ` Andrew Lunn
2018-02-06 16:58 ` Sven Van Asbroeck
2018-02-06 17:05 ` Andrew Lunn
2018-02-06 17:47 ` Florian Fainelli [this message]
2018-02-06 18:11 ` Sven Van Asbroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f18b10f-1c84-f386-2b13-12163c0fd8a5@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Maarten.Blomme@flir.com \
--cc=Tristram.Ha@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=helmut.buchsbaum@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=svendev@arcx.com \
--cc=thesven73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).