Re: [PATCH iproute2-next 0/4] ip: Introduce and use helper to read /proc/net/dev

[Serhey Popovych <serhe.popovych@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1797 bytes --]

Stephen Hemminger wrote:
> On Wed, 31 Jan 2018 21:49:45 +0200
> Serhey Popovych <serhe.popovych@gmail.com> wrote:
> 
>> Currently there is two places in ip(8) where /proc/net/dev is read line
>> by line with nearly identical steps: iptunnel.c and ip6tunnel.c
>>
>> On the other hand we have iptuntap.c that uses /sys/class/net that could
>> be problematic in case of unshare(1)d network namespace without sysfs
>> being mounted.
>>
>> Introduce and use do_each_proc_net_dev() helper to read data from
>> /proc/net/dev line by line and pass this information to implementation
>> specific callback function.
>>
>> See individual patch description message for more details.
>>
>> Series is open for reviews and comments.
>>
>> Tested only by compiling and executing ip [-46] [-s] [-d] tunnel in
>> various combinations: no problem so far. More can be done by request.
>>
>> Thanks,
>> Serhii
>>
>> Serhey Popovych (4):
>>   utils: Introduce do_each_proc_net_dev() helper
>>   iptunnel: Use do_each_proc_net_dev()
>>   ip6tunnel: Use do_each_proc_net_dev()
>>   tuntap: Use do_each_proc_net_dev()
>>
>>  include/utils.h |   10 ++++++
>>  ip/ip6tunnel.c  |   94 ++++++++++++++++++++------------------------------
>>  ip/iptunnel.c   |  102 +++++++++++++++++++++++++------------------------------
>>  ip/iptuntap.c   |   59 ++++++++++++++------------------
>>  lib/utils.c     |   51 ++++++++++++++++++++++++++++
>>  5 files changed, 170 insertions(+), 146 deletions(-)
>>
> 
> /proc/net/dev is legacy and unextensible.
> 
> I would rather see netlink used everywhere and not /proc/net/dev or sysfs!
> 

Look at my RFC series against iproute2-next with cover letter subject:
"ip: Use netlink to walk through network device list".

Thanks,
Serhii





[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]