Re: [PATCH net-next] dpaa_eth: don't use fixed_phy_change_carrier

[Jacob Keller <jacob.e.keller@intel.com>]

On 6/16/2025 4:44 PM, Andrew Lunn wrote:
> On Mon, Jun 16, 2025 at 03:47:57PM -0700, Jacob Keller wrote:
>>
>>
>> On 6/16/2025 2:24 PM, Heiner Kallweit wrote:
>>> This effectively reverts 6e8b0ff1ba4c ("dpaa_eth: Add change_carrier()
>>> for Fixed PHYs"). Usage of fixed_phy_change_carrier() requires that
>>> fixed_phy_register() has been called before, directly or indirectly.
>>> And that's not the case in this driver.
>>>
>>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>>> ---
>>
>> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
>>
>> Is this harmful to leave set if fixed_phy_register() is not called? If
>> so then this could be net + a fixes tag instead of net-next.
> 
> It appears to be used if you echo something to
> /sys/class/net/eth42/carrier. It will return EINVAL.
> 
> The same will happen if you use do_set_proto_down() via rtnetlink.
> 
> Apart from the EINVAL returned to userspace, nothing bad will happen.
> So i don't think this needs a Fixes: tag.
> 
> 	Andrew

Thanks! Makes sense to keep it as a net-next cleanup then.