From: Yonghong Song <yhs@fb.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Network Development <netdev@vger.kernel.org>,
bpf <bpf@vger.kernel.org>, Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH v2 bpf-next 2/3] bpf: Fix propagation of signed bounds from 64-bit min/max into 32-bit.
Date: Mon, 1 Nov 2021 16:11:54 -0700 [thread overview]
Message-ID: <2f6df382-e752-2a53-0d2e-5d46c0567bff@fb.com> (raw)
In-Reply-To: <CAADnVQLYf-tqV7efxgeHQ8K_130r_v_8Zft2wBVBZn0EYOzm6A@mail.gmail.com>
On 11/1/21 4:06 PM, Alexei Starovoitov wrote:
> On Mon, Nov 1, 2021 at 4:03 PM Yonghong Song <yhs@fb.com> wrote:
>>
>>
>>
>> On 11/1/21 3:21 PM, Alexei Starovoitov wrote:
>>> From: Alexei Starovoitov <ast@kernel.org>
>>>
>>> Similar to unsigned bounds propagation fix signed bounds.
>>> The 'Fixes' tag is a hint. There is no security bug here.
>>> The verifier was too conservative.
>>>
>>> Fixes: 3f50f132d840 ("bpf: Verifier, do explicit ALU32 bounds tracking")
>>> Signed-off-by: Alexei Starovoitov <ast@kernel.org>
>>
>> The change looks good. Should a new test_verifier test be added
>> to exercise the new change?
>
> I think manually string comparing output the way VERBOSE_ACCEPT is doing
> is an overkill here.
> The real test case in .c will take some time to craft.
Okay. Sounds good to me.
Acked-by: Yonghong Song <yhs@fb.com>
next prev parent reply other threads:[~2021-11-01 23:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 22:21 [PATCH v2 bpf-next 1/3] bpf: Fix propagation of bounds from 64-bit min/max into 32-bit and var_off Alexei Starovoitov
2021-11-01 22:21 ` [PATCH v2 bpf-next 2/3] bpf: Fix propagation of signed bounds from 64-bit min/max into 32-bit Alexei Starovoitov
2021-11-01 23:03 ` Yonghong Song
2021-11-01 23:06 ` Alexei Starovoitov
2021-11-01 23:11 ` Yonghong Song [this message]
2021-11-01 22:21 ` [PATCH v2 bpf-next 3/3] selftests/bpf: Add a testcase for 64-bit bounds propagation issue Alexei Starovoitov
2021-11-02 1:10 ` [PATCH v2 bpf-next 1/3] bpf: Fix propagation of bounds from 64-bit min/max into 32-bit and var_off patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f6df382-e752-2a53-0d2e-5d46c0567bff@fb.com \
--to=yhs@fb.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox