From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net-next 0/2] platform data controls for mdio-gpio Date: Thu, 6 Dec 2018 09:22:27 -0800 Message-ID: <2f976fc3-7691-3190-3e66-729cfadb86a4@gmail.com> References: <1544104723-17857-1-git-send-email-andrew@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Heiner Kallweit , netdev To: Andrew Lunn , David Miller Return-path: Received: from mail-pf1-f194.google.com ([209.85.210.194]:39193 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725862AbeLFRWf (ORCPT ); Thu, 6 Dec 2018 12:22:35 -0500 Received: by mail-pf1-f194.google.com with SMTP id c72so492661pfc.6 for ; Thu, 06 Dec 2018 09:22:34 -0800 (PST) In-Reply-To: <1544104723-17857-1-git-send-email-andrew@lunn.ch> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Hi Andrew, On 12/6/18 5:58 AM, Andrew Lunn wrote: > Soon to be mainlined is an x86 platform with a Marvell switch, and a > bit-banging MDIO bus. In order to make this work, the phy_mask of the > MDIO bus needs to be set to prevent scanning for PHYs, and the > phy_ignore_ta_mask needs to be set because the switch has broken > turnaround. This looks good, I would just make one/two changes which is to match the internal phy_mask and phy_ignore_ta_mask types from the struct mii_bus and use u32 instead of int. > > Add a platform_data structure with these parameters. > > Andrew Lunn (2): > net: phy: mdio-gpio: Add platform_data support for phy_mask > net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform data > > MAINTAINERS | 1 + > drivers/net/phy/mdio-gpio.c | 7 +++++++ > include/linux/platform_data/mdio-gpio.h | 14 ++++++++++++++ > 3 files changed, 22 insertions(+) > create mode 100644 include/linux/platform_data/mdio-gpio.h > -- Florian