From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Chapman Subject: Re: [PATCH net-next 3/4] l2tp: remove configurable payload offset Date: Thu, 4 Jan 2018 12:36:26 +0000 Message-ID: <2f985bb7-da3b-7792-a83f-cdbd3061a368@katalix.com> References: <1515019687-1556-1-git-send-email-jchapman@katalix.com> <1515019687-1556-4-git-send-email-jchapman@katalix.com> <20180104102503.GG1402@alphalink.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, lorenzo.bianconi@redhat.com, liuhangbin@gmail.com To: Guillaume Nault Return-path: Received: from mail.katalix.com ([82.103.140.233]:34355 "EHLO mail.katalix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751827AbeADMg3 (ORCPT ); Thu, 4 Jan 2018 07:36:29 -0500 In-Reply-To: <20180104102503.GG1402@alphalink.fr> Content-Language: en-GB Sender: netdev-owner@vger.kernel.org List-ID: On 04/01/18 10:25, Guillaume Nault wrote: >> diff --git a/net/l2tp/l2tp_debugfs.c b/net/l2tp/l2tp_debugfs.c >> index eb69411..2c30587 100644 >> --- a/net/l2tp/l2tp_debugfs.c >> +++ b/net/l2tp/l2tp_debugfs.c >> @@ -180,8 +180,8 @@ static void l2tp_dfs_seq_session_show(struct seq_file *m, void *v) >> session->lns_mode ? "LNS" : "LAC", >> session->debug, >> jiffies_to_msecs(session->reorder_timeout)); >> - seq_printf(m, " offset %hu l2specific %hu/%hu\n", >> - session->offset, session->l2specific_type, session->l2specific_len); >> + seq_printf(m, " offset 0 l2specific %hu/%hu\n", >> + session->l2specific_type, session->l2specific_len); >> > Can't we drop "offset" completely? That would change the debugfs file layout. If we remove it, we should also update the header line which is in the debugs output and is intended to indicate the layout of data. James