From: Nikolay Aleksandrov <razor@blackwall.org>
To: Ido Schimmel <idosch@nvidia.com>,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, roopa@nvidia.com, mlxsw@nvidia.com
Subject: Re: [PATCH net-next 04/14] bridge: mcast: Add a centralized error path
Date: Fri, 9 Dec 2022 09:30:21 +0200 [thread overview]
Message-ID: <2fa88776-fc7e-564c-18d9-83c75414b838@blackwall.org> (raw)
In-Reply-To: <20221208152839.1016350-5-idosch@nvidia.com>
On 08/12/2022 17:28, Ido Schimmel wrote:
> Subsequent patches will add memory allocations in br_mdb_config_init()
> as the MDB configuration structure will include a linked list of source
> entries. This memory will need to be freed regardless if br_mdb_add()
> succeeded or failed.
>
> As a preparation for this change, add a centralized error path where the
> memory will be freed.
>
> Note that br_mdb_del() already has one error path and therefore does not
> require any changes.
>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> ---
> net/bridge/br_mdb.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
next prev parent reply other threads:[~2022-12-09 7:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 15:28 [PATCH net-next 00/14] bridge: mcast: Extensions for EVPN Ido Schimmel
2022-12-08 15:28 ` [PATCH net-next 01/14] bridge: mcast: Do not derive entry type from its filter mode Ido Schimmel
2022-12-09 7:27 ` Nikolay Aleksandrov
2022-12-08 15:28 ` [PATCH net-next 02/14] bridge: mcast: Split (*, G) and (S, G) addition into different functions Ido Schimmel
2022-12-09 7:29 ` Nikolay Aleksandrov
2022-12-08 15:28 ` [PATCH net-next 03/14] bridge: mcast: Place netlink policy before validation functions Ido Schimmel
2022-12-09 7:30 ` Nikolay Aleksandrov
2022-12-08 15:28 ` [PATCH net-next 04/14] bridge: mcast: Add a centralized error path Ido Schimmel
2022-12-09 7:30 ` Nikolay Aleksandrov [this message]
2022-12-08 15:28 ` [PATCH net-next 05/14] bridge: mcast: Expose br_multicast_new_group_src() Ido Schimmel
2022-12-09 7:30 ` Nikolay Aleksandrov
2022-12-08 15:28 ` [PATCH net-next 06/14] bridge: mcast: Expose __br_multicast_del_group_src() Ido Schimmel
2022-12-09 7:31 ` Nikolay Aleksandrov
2022-12-08 15:28 ` [PATCH net-next 07/14] bridge: mcast: Add a flag for user installed source entries Ido Schimmel
2022-12-09 7:32 ` Nikolay Aleksandrov
2022-12-08 15:28 ` [PATCH net-next 08/14] bridge: mcast: Avoid arming group timer when (S, G) corresponds to a source Ido Schimmel
2022-12-09 7:32 ` Nikolay Aleksandrov
2022-12-08 15:28 ` [PATCH net-next 09/14] bridge: mcast: Add support for (*, G) with a source list and filter mode Ido Schimmel
2022-12-09 7:41 ` Nikolay Aleksandrov
2022-12-10 13:33 ` Ido Schimmel
2022-12-08 15:28 ` [PATCH net-next 10/14] bridge: mcast: Allow user space to add " Ido Schimmel
2022-12-09 7:52 ` Nikolay Aleksandrov
2022-12-08 15:28 ` [PATCH net-next 11/14] bridge: mcast: Allow user space to specify MDB entry routing protocol Ido Schimmel
2022-12-09 7:53 ` Nikolay Aleksandrov
2022-12-08 15:28 ` [PATCH net-next 12/14] bridge: mcast: Support replacement of MDB port group entries Ido Schimmel
2022-12-09 8:08 ` Nikolay Aleksandrov
2022-12-10 13:59 ` Ido Schimmel
2022-12-08 15:28 ` [PATCH net-next 13/14] selftests: forwarding: Rename bridge_mdb test Ido Schimmel
2022-12-09 8:09 ` Nikolay Aleksandrov
2022-12-08 15:28 ` [PATCH net-next 14/14] selftests: forwarding: Add bridge MDB test Ido Schimmel
2022-12-09 8:09 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fa88776-fc7e-564c-18d9-83c75414b838@blackwall.org \
--to=razor@blackwall.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).