From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90FFBC3A5A1 for ; Wed, 28 Aug 2019 16:22:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 75DC2217F5 for ; Wed, 28 Aug 2019 16:22:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726773AbfH1QW2 convert rfc822-to-8bit (ORCPT ); Wed, 28 Aug 2019 12:22:28 -0400 Received: from mga09.intel.com ([134.134.136.24]:29145 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726400AbfH1QW2 (ORCPT ); Wed, 28 Aug 2019 12:22:28 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Aug 2019 09:22:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,441,1559545200"; d="scan'208";a="188268532" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 28 Aug 2019 09:22:27 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 28 Aug 2019 09:22:26 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 28 Aug 2019 09:22:26 -0700 Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmsx602.amr.corp.intel.com ([10.18.126.82]) with mapi id 15.01.1713.004; Wed, 28 Aug 2019 09:22:26 -0700 From: "Bowers, AndrewX" To: "open list:NETWORKING DRIVERS" , "moderated list:INTEL ETHERNET DRIVERS" , open list Subject: RE: [Intel-wired-lan] [PATCH] net: ixgbe: fix memory leaks Thread-Topic: [Intel-wired-lan] [PATCH] net: ixgbe: fix memory leaks Thread-Index: AQHVUIBxRlDNf2eVNEGHgWL/fUZ44qcQ2GfQ Date: Wed, 28 Aug 2019 16:22:26 +0000 Message-ID: <2fb9767372fa4d5aaaab74c7e60561fe@intel.com> References: <1565554067-4994-1-git-send-email-wenwen@cs.uga.edu> In-Reply-To: <1565554067-4994-1-git-send-email-wenwen@cs.uga.edu> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2MyOTA2OTctNmM4OC00N2JjLWI1OGItM2E2MTQyZTc1YTIxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiM25kdVlnakpEeCsyTHZrRWVXTG9haFVNUU5zc3V6MjFaSEV4T0dwWWNHOXBYSGtaVzZCSnRqUXZvVFhZQ09qRSJ9 dlp-reaction: no-action dlp-version: 11.0.400.15 x-originating-ip: [10.22.254.132] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > -----Original Message----- > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On > Behalf Of Wenwen Wang > Sent: Sunday, August 11, 2019 1:08 PM > To: Wenwen Wang > Cc: open list:NETWORKING DRIVERS ; moderated > list:INTEL ETHERNET DRIVERS ; open list > ; David S. Miller > Subject: [Intel-wired-lan] [PATCH] net: ixgbe: fix memory leaks > > In ixgbe_configure_clsu32(), 'jump', 'input', and 'mask' are allocated through > kzalloc() respectively in a for loop body. Then, > ixgbe_clsu32_build_input() is invoked to build the input. If this process fails, > next iteration of the for loop will be executed. However, the allocated > 'jump', 'input', and 'mask' are not deallocated on this execution path, leading > to memory leaks. > > Signed-off-by: Wenwen Wang > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 ++++ > 1 file changed, 4 insertions(+) Tested-by: Andrew Bowers