From: Jason Wang <jasowang@redhat.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Tanner Love <tannerlove.kernel@gmail.com>,
Network Development <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Petar Penkov <ppenkov@google.com>,
Jakub Kicinski <kuba@kernel.org>,
"Michael S . Tsirkin" <mst@redhat.com>,
Tanner Love <tannerlove@google.com>
Subject: Re: [PATCH net-next v4 2/3] virtio_net: add optional flow dissection in virtio_net_hdr_to_skb
Date: Thu, 10 Jun 2021 13:23:44 +0800 [thread overview]
Message-ID: <2fd24801-bf77-02e3-03f5-b5e8fac595b6@redhat.com> (raw)
In-Reply-To: <CAADnVQL_+oKjH341ccC_--ing6dviAPwWRocgYrTKidkKo-NcA@mail.gmail.com>
在 2021/6/10 下午12:19, Alexei Starovoitov 写道:
> On Wed, Jun 9, 2021 at 9:13 PM Jason Wang <jasowang@redhat.com> wrote:
>> So I wonder why not simply use helpers to access the vnet header like
>> how tcp-bpf access the tcp header?
> Short answer - speed.
> tcp-bpf accesses all uapi and non-uapi structs directly.
>
Ok, this makes sense. But instead of coupling device specific stuffs
like vnet header and neediness into general flow_keys as a context.
It would be better to introduce a vnet header context which contains
1) vnet header
2) flow keys
3) other contexts like endian and virtio-net features
So we preserve the performance and decouple the virtio-net stuffs from
general structures like flow_keys or __sk_buff.
Thanks
next prev parent reply other threads:[~2021-06-10 5:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 17:02 [PATCH net-next v4 0/3] virtio_net: add optional flow dissection in virtio_net_hdr_to_skb Tanner Love
2021-06-08 17:02 ` [PATCH net-next v4 1/3] net: flow_dissector: extend bpf flow dissector support with vnet hdr Tanner Love
2021-06-08 22:08 ` Martin KaFai Lau
[not found] ` <CAOckAf8W04ynA4iXXzBe8kB_yauH9TKEJ_o6tt9tQuTJBx-G6A@mail.gmail.com>
2021-06-09 18:24 ` Martin KaFai Lau
2021-06-08 17:02 ` [PATCH net-next v4 2/3] virtio_net: add optional flow dissection in virtio_net_hdr_to_skb Tanner Love
2021-06-10 3:09 ` Jason Wang
2021-06-10 3:15 ` Willem de Bruijn
2021-06-10 3:53 ` Jason Wang
2021-06-10 4:05 ` Alexei Starovoitov
2021-06-10 4:13 ` Jason Wang
2021-06-10 4:19 ` Alexei Starovoitov
2021-06-10 5:23 ` Jason Wang [this message]
2021-06-10 14:04 ` Willem de Bruijn
2021-06-11 2:10 ` Jason Wang
2021-06-11 2:45 ` Willem de Bruijn
2021-06-11 3:38 ` Jason Wang
2021-06-11 14:12 ` Willem de Bruijn
2021-06-14 20:41 ` Tanner Love
2021-06-15 8:57 ` Jason Wang
2021-06-15 8:55 ` Jason Wang
2021-06-15 14:47 ` Willem de Bruijn
2021-06-16 10:21 ` Jason Wang
2021-06-17 14:43 ` Willem de Bruijn
2021-06-21 6:33 ` Jason Wang
2021-06-21 13:18 ` Willem de Bruijn
2021-06-22 2:37 ` Jason Wang
2021-06-08 17:02 ` [PATCH net-next v4 3/3] selftests/net: amend bpf flow dissector prog to do vnet hdr validation Tanner Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fd24801-bf77-02e3-03f5-b5e8fac595b6@redhat.com \
--to=jasowang@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=ppenkov@google.com \
--cc=tannerlove.kernel@gmail.com \
--cc=tannerlove@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).