From: David Ahern <dsahern@kernel.org>
To: Simon Horman <simon.horman@corigine.com>,
Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v1 net-next] ipv6: rpl: Remove redundant skb_dst_drop().
Date: Wed, 12 Jul 2023 08:42:27 -0600 [thread overview]
Message-ID: <2fda9e96-cefc-fcee-063c-cdf652a64992@kernel.org> (raw)
In-Reply-To: <ZK6Q5bp7cYhfl6iN@corigine.com>
On 7/12/23 5:39 AM, Simon Horman wrote:
> On Mon, Jul 10, 2023 at 02:35:11PM -0700, Kuniyuki Iwashima wrote:
>> RPL code has a pattern where skb_dst_drop() is called before
>> ip6_route_input().
>>
>> However, ip6_route_input() calls skb_dst_drop() internally,
>> so we need not call skb_dst_drop() before ip6_route_input().
>>
>> Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
>
I have been ignoring net-next patches since net-next status still shows
as closed.
next prev parent reply other threads:[~2023-07-12 14:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 21:35 [PATCH v1 net-next] ipv6: rpl: Remove redundant skb_dst_drop() Kuniyuki Iwashima
2023-07-12 11:39 ` Simon Horman
2023-07-12 14:42 ` David Ahern [this message]
2023-07-12 14:54 ` David Ahern
2023-07-13 8:53 ` Simon Horman
2023-07-13 0:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fda9e96-cefc-fcee-063c-cdf652a64992@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).