From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Samudrala, Sridhar" Subject: Re: [PATCH net] failover: eliminate callback hell Date: Mon, 11 Jun 2018 17:08:29 -0700 Message-ID: <2ffcd7c4-17bf-2e7b-fd48-d61b2a6f2ade@intel.com> References: <20180605034231.31610-1-sthemmin@microsoft.com> <20180611210819-mutt-send-email-mst@kernel.org> <04210bba-f67a-dd10-cdce-c7d140dcecbe@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Cc: kys@microsoft.com, haiyangz@microsoft.com, davem@davemloft.net, netdev@vger.kernel.org, Stephen Hemminger To: "Michael S. Tsirkin" , Stephen Hemminger Return-path: Received: from mga11.intel.com ([192.55.52.93]:51855 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933016AbeFLAIc (ORCPT ); Mon, 11 Jun 2018 20:08:32 -0400 In-Reply-To: <04210bba-f67a-dd10-cdce-c7d140dcecbe@intel.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 6/11/2018 12:34 PM, Samudrala, Sridhar wrote: > > On 6/11/2018 11:10 AM, Michael S. Tsirkin wrote: >> On Mon, Jun 04, 2018 at 08:42:31PM -0700, Stephen Hemminger wrote: >>>    * Set permanent and current address of net_failover device >>>      to match the primary. We copy the dev_addr of standby dev to failover_dev in net_failover_create() before calling register_netdev(). register_netdev() does a copy of dev_addr to perm_addr. So i don't think this is an issue. >>> >>>    * Carrier should be marked off before registering device >>>      the net_failover device. Will fix this and also a couple of places dev_err() needs to be replaced with netdev_err() >> Sridhar, do we want to address this? >> If yes, could you please take a look at addressing these >> meanwhile, while we keep arguing about making API changes? > > Sure. I will submit patches to address these issues raised by Stephen. > >