From: "Coelho, Luciano" <luciano.coelho@intel.com>
To: "kvalo@kernel.org" <kvalo@kernel.org>,
"gustavoars@kernel.org" <gustavoars@kernel.org>
Cc: "keescook@chromium.org" <keescook@chromium.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"linux-hardening@vger.kernel.org"
<linux-hardening@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH][next] iwlwifi: mei: Replace zero-length array with flexible-array member
Date: Fri, 1 Apr 2022 08:10:26 +0000 [thread overview]
Message-ID: <2fff1c4d0efdcda670ddc3683e383f6472d91e85.camel@intel.com> (raw)
In-Reply-To: <87wngezkyf.fsf@kernel.org>
On Mon, 2022-03-28 at 08:48 +0300, Kalle Valo wrote:
> "Gustavo A. R. Silva" <gustavoars@kernel.org> writes:
>
> > On Wed, Feb 16, 2022 at 12:35:22PM -0800, Kees Cook wrote:
> > > On Wed, Feb 16, 2022 at 01:50:30PM -0600, Gustavo A. R. Silva wrote:
> > > > There is a regular need in the kernel to provide a way to declare
> > > > having a dynamically sized set of trailing elements in a structure.
> > > > Kernel code should always use “flexible array members”[1] for these
> > > > cases. The older style of one-element or zero-length arrays should
> > > > no longer be used[2].
> > > >
> > > > [1] https://en.wikipedia.org/wiki/Flexible_array_member
> > > > [2]
> > > > https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
> > > >
> > > > Link: https://github.com/KSPP/linux/issues/78
> > > > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> > >
> > > Reviewed-by: Kees Cook <keescook@chromium.org>
> >
> > Hi all,
> >
> > Friendly ping: can someone take this, please?
> >
> > ...I can take this in my -next tree in the meantime.
>
> I'll take this. Luca, ack?
Acked-by: Luca Coelho <luciano.coelho@intel.com>
--
Cheers,
Luca.
next prev parent reply other threads:[~2022-04-01 8:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 19:50 [PATCH][next] iwlwifi: mei: Replace zero-length array with flexible-array member Gustavo A. R. Silva
2022-02-16 20:35 ` Kees Cook
2022-03-26 0:41 ` Gustavo A. R. Silva
2022-03-28 5:48 ` Kalle Valo
2022-04-01 8:10 ` Coelho, Luciano [this message]
2022-04-06 7:19 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fff1c4d0efdcda670ddc3683e383f6472d91e85.camel@intel.com \
--to=luciano.coelho@intel.com \
--cc=davem@davemloft.net \
--cc=gustavoars@kernel.org \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).