From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC747C2BBCA for ; Tue, 8 Dec 2020 20:20:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 863E22388C for ; Tue, 8 Dec 2020 20:20:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729053AbgLHUUn (ORCPT ); Tue, 8 Dec 2020 15:20:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725910AbgLHURu (ORCPT ); Tue, 8 Dec 2020 15:17:50 -0500 Received: from mail-ot1-x341.google.com (mail-ot1-x341.google.com [IPv6:2607:f8b0:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66305C0613D6; Tue, 8 Dec 2020 12:17:15 -0800 (PST) Received: by mail-ot1-x341.google.com with SMTP id w3so16382630otp.13; Tue, 08 Dec 2020 12:17:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RDpBBRXCwLTGCWL5RwRoMW+K4EoFZfULoP1L0KjbLbQ=; b=irYTzobUKoW2lTGMu/IWGq9PzYpzkIqG/jEAnrHZvn6pVpX2kuaedn1rquvYZ3zMW6 94lYdQyny/ZYxLO2vEtHun0VkZ05N0V05vQkq7+/93gidt0MrRCblN0I6BaAIUZAZVuk Jt3U3xCq/QRqFv106yddgu2FhANtxChbXL1JX1LfSUOQCsbWCGu3TeCZ91Vy8o8IDKvL TWpodQEg6hOkt44m4LWIVdFgq9+ZaM5+FCtlCL0NLTJMTu3pOXMe8F39i1O3QUB8NliM QEvxY9NXUPIrOIVCmFcX/UYA30fz5gnmpMVz6gMwCIqefRr9VPzWFyI98zLzoTrpQQFQ Mm7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RDpBBRXCwLTGCWL5RwRoMW+K4EoFZfULoP1L0KjbLbQ=; b=IX7EdcfsInH8uFUe9ocoBSM+3ggi4qQzT492ztJmoN6TOc2rewKm3sq8OLwXitPOVS fAmNRodx8AvOCOp7S6Ndif2lVBKt34yWqlr9Vmq+XmBXFj4TuBFm3yKBlWvhwqxqx1QD moqGGu/qOtASOV3+TM1XpRkM5OFqbD+H+wgDD3j8dzq0JIV/SsXKavy9n3M1Nz6mR3Db FlRqkGn01ZGh21XVvhr0er72eezplPI7B8fkOB53DxUIhXrlFm07VBF6s6mx4sNGdQiF +AH/tRK9aFctwSw42oZBO6vogBdiEmDNrhu1KGT05XNTaV15qyP6gdSWfqeydq05JnYt 4GYw== X-Gm-Message-State: AOAM5328BMclyiCbQTvX7BSyWqFFOE9v7tOwvocWua1VqeUENYnwU15r dP4Kv84OBcWZ3qyS2gg2k+829e4BkVM= X-Google-Smtp-Source: ABdhPJxTVQtJ6ItkrXTOaZOAp9aFVPMT53csV3Hgbgb4zzflb5HrNL1wyLpoX7m9Gyyvf6EphLsnHw== X-Received: by 2002:a9d:2ae3:: with SMTP id e90mr18256256otb.105.1607457118066; Tue, 08 Dec 2020 11:51:58 -0800 (PST) Received: from Davids-MacBook-Pro.local ([8.48.134.51]) by smtp.googlemail.com with ESMTPSA id m18sm1321249ooa.24.2020.12.08.11.51.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Dec 2020 11:51:57 -0800 (PST) Subject: Re: [PATCH net-next] vrf: handle CONFIG_IPV6 not set for vrf_add_mac_header_if_unset() To: Andrea Mayer , "David S. Miller" , David Ahern , Jakub Kicinski , Shrijeet Mukherjee , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Stefano Salsano , Paolo Lungaroni , Ahmed Abdelsalam , kernel test robot References: <20201208175210.8906-1-andrea.mayer@uniroma2.it> From: David Ahern Message-ID: <30116173-cc7f-f492-f290-faa24db28864@gmail.com> Date: Tue, 8 Dec 2020 12:51:55 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20201208175210.8906-1-andrea.mayer@uniroma2.it> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 12/8/20 10:52 AM, Andrea Mayer wrote: > The vrf_add_mac_header_if_unset() is defined within a conditional > compilation block which depends on the CONFIG_IPV6 macro. > However, the vrf_add_mac_header_if_unset() needs to be called also by IPv4 > related code and when the CONFIG_IPV6 is not set, this function is missing. > As a consequence, the build process stops reporting the error: > > ERROR: implicit declaration of function 'vrf_add_mac_header_if_unset' > > The problem is solved by *only* moving functions > vrf_add_mac_header_if_unset() and vrf_prepare_mac_header() out of the > conditional block. > > Reported-by: kernel test robot > Fixes: 0489390882202 ("vrf: add mac header for tunneled packets when sniffer is attached") > Signed-off-by: Andrea Mayer > --- > drivers/net/vrf.c | 110 +++++++++++++++++++++++----------------------- > 1 file changed, 55 insertions(+), 55 deletions(-) > I should have caught that in my review. Reviewed-by: David Ahern