From: "Rémi Denis-Courmont" <remi.denis-courmont@nokia.com>
To: ext Hemant-vilas RAMDASI <hemant.ramdasi@stericsson.com>
Cc: Srinidhi KASAGAR <srinidhi.kasagar@stericsson.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: about phonet pipe controller
Date: Wed, 12 Oct 2011 10:58:05 +0300 [thread overview]
Message-ID: <3025840.a3oI7lSnik@leon.remlab.net> (raw)
In-Reply-To: <81C3A93C17462B4BBD7E272753C105791EAACAE76F@EXDCVYMBSTM005.EQ1STM.local>
Le Mercredi 12 Octobre 2011 09:25:01 ext Hemant-vilas RAMDASI a écrit :
> You have mentioned in the
> "a015f6f: Phonet: kill the ST-Ericsson pipe controller Kconfig",
> that "Support for manually enabling the pipe flow is removed as it
> did not work properly, does not fit well with the socket API, and
> I am not aware of any use at the moment.."
>
> On STE U8500 modem, you must first create pipe in disabled state, then do
> local link configuration (does't work when pipe is enabled) & then enable
> pipe.
The Kconfig option broke support for existing hardware (Nokia N900 as a USB
gadget) and userspace (namely the oFono ISI driver). We cannot expect
distributions to provide two different kernel builds for different flavors of ISI
modems.
> Because of this connect() cannot be used anymore and it needs to be modified
> to reintroduce pipe-controller functionality again.
As far as I can tell, that code NEVER worked properly. Not only the use of a
build-time option is inappropriate, but the code did not deal with a number of
new corner cases that it introduced.
> Do you have any suggestions?
I'm sorry but I don't really get where you're trying to get. The code had more
bugs than I could fix by myself, especially when I don't have the hardware and
the specification.
--
Rémi Denis-Courmont
http://www.remlab.net/
next prev parent reply other threads:[~2011-10-12 7:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 7:25 about phonet pipe controller Hemant-vilas RAMDASI
2011-10-12 7:58 ` Rémi Denis-Courmont [this message]
2011-10-12 10:58 ` Hemant-vilas RAMDASI
2011-10-12 11:08 ` Rémi Denis-Courmont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3025840.a3oI7lSnik@leon.remlab.net \
--to=remi.denis-courmont@nokia.com \
--cc=hemant.ramdasi@stericsson.com \
--cc=netdev@vger.kernel.org \
--cc=srinidhi.kasagar@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).