netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jay Vosburgh <fubar@us.ibm.com>
To: "Weiping Pan(潘卫平)" <panweiping3@gmail.com>
Cc: andy@greyhouse.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bonding:set save_load to 0 when initializing
Date: Mon, 11 Apr 2011 11:56:47 -0700	[thread overview]
Message-ID: <30474.1302548207@death> (raw)
In-Reply-To: <1302270019-11698-1-git-send-email-panweiping3@gmail.com>


>It is unnecessary to set save_load to 1 here,
>as the tx_hashtbl is just kzalloced.
>
>Signed-off-by: Weiping Pan(潘卫平) <panweiping3@gmail.com>

	I don't think this will cause any behavioral change, but I'll
grant is more correct in intent (there's no load information to save at
this point).

Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>

>---
> drivers/net/bonding/bond_alb.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
>index 9bc5de3..ab69e5a 100644
>--- a/drivers/net/bonding/bond_alb.c
>+++ b/drivers/net/bonding/bond_alb.c
>@@ -176,7 +176,7 @@ static int tlb_initialize(struct bonding *bond)
> 	bond_info->tx_hashtbl = new_hashtbl;
>
> 	for (i = 0; i < TLB_HASH_TABLE_SIZE; i++) {
>-		tlb_init_table_entry(&bond_info->tx_hashtbl[i], 1);
>+		tlb_init_table_entry(&bond_info->tx_hashtbl[i], 0);
> 	}
>
> 	_unlock_tx_hashtbl(bond);
>-- 
>1.7.4
>

  reply	other threads:[~2011-04-11 18:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-08 13:40 [PATCH] bonding:set save_load to 0 when initializing Weiping Pan(潘卫平)
2011-04-11 18:56 ` Jay Vosburgh [this message]
2011-04-11 20:16   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30474.1302548207@death \
    --to=fubar@us.ibm.com \
    --cc=andy@greyhouse.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=panweiping3@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).