From: Sagi Grimberg <sagi@grimberg.me>
To: Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 17/17] nvmet-tcp: peek icreq before starting TLS
Date: Mon, 14 Aug 2023 15:11:56 +0300 [thread overview]
Message-ID: <304bc2f7-5f77-6e08-bcdb-f382233f611b@grimberg.me> (raw)
In-Reply-To: <20230814111943.68325-18-hare@suse.de>
> Incoming connection might be either 'normal' NVMe-TCP connections
> starting with icreq or TLS handshakes. To ensure that 'normal'
> connections can still be handled we need to peek the first packet
> and only start TLS handshake if it's not an icreq.
That depends if we want to do that.
Why should we let so called normal connections if tls1.3 is
enabled?
next prev parent reply other threads:[~2023-08-14 12:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 11:19 [PATCHv8 00/17] nvme: In-kernel TLS support for TCP Hannes Reinecke
2023-08-14 11:19 ` [PATCH 01/17] nvme-keyring: register '.nvme' keyring Hannes Reinecke
2023-08-14 11:19 ` [PATCH 02/17] nvme-keyring: define a 'psk' keytype Hannes Reinecke
2023-08-14 11:19 ` [PATCH 03/17] nvme: add TCP TSAS definitions Hannes Reinecke
2023-08-14 11:19 ` [PATCH 04/17] nvme-tcp: add definitions for TLS cipher suites Hannes Reinecke
2023-08-14 11:19 ` [PATCH 05/17] nvme-keyring: implement nvme_tls_psk_default() Hannes Reinecke
2023-08-14 11:19 ` [PATCH 06/17] security/keys: export key_lookup() Hannes Reinecke
2023-08-14 11:19 ` [PATCH 07/17] nvme-tcp: allocate socket file Hannes Reinecke
2023-08-14 11:19 ` [PATCH 08/17] nvme-tcp: enable TLS handshake upcall Hannes Reinecke
2023-08-14 11:19 ` [PATCH 09/17] nvme-tcp: control message handling for recvmsg() Hannes Reinecke
2023-08-14 11:19 ` [PATCH 10/17] nvme-fabrics: parse options 'keyring' and 'tls_key' Hannes Reinecke
2023-08-14 12:07 ` Sagi Grimberg
2023-08-14 11:19 ` [PATCH 11/17] nvmet: make TCP sectype settable via configfs Hannes Reinecke
2023-08-14 11:19 ` [PATCH 12/17] nvmet-tcp: make nvmet_tcp_alloc_queue() a void function Hannes Reinecke
2023-08-14 11:19 ` [PATCH 13/17] nvmet-tcp: allocate socket file Hannes Reinecke
2023-08-14 11:19 ` [PATCH 14/17] nvmet: Set 'TREQ' to 'required' when TLS is enabled Hannes Reinecke
2023-08-14 11:19 ` [PATCH 15/17] nvmet-tcp: enable TLS handshake upcall Hannes Reinecke
2023-08-14 12:48 ` Sagi Grimberg
2023-08-14 14:03 ` Hannes Reinecke
2023-08-14 19:12 ` Sagi Grimberg
2023-08-15 6:29 ` Hannes Reinecke
2023-08-15 7:01 ` Sagi Grimberg
2023-08-15 7:20 ` Hannes Reinecke
2023-08-15 13:34 ` Sagi Grimberg
2023-08-15 15:04 ` Hannes Reinecke
2023-08-14 11:19 ` [PATCH 16/17] nvmet-tcp: control messages for recvmsg() Hannes Reinecke
2023-08-14 12:08 ` Sagi Grimberg
2023-08-14 11:19 ` [PATCH 17/17] nvmet-tcp: peek icreq before starting TLS Hannes Reinecke
2023-08-14 12:11 ` Sagi Grimberg [this message]
2023-08-14 13:18 ` Hannes Reinecke
2023-08-14 19:05 ` Sagi Grimberg
2023-08-15 6:20 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=304bc2f7-5f77-6e08-bcdb-f382233f611b@grimberg.me \
--to=sagi@grimberg.me \
--cc=edumazet@google.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).