From: Jay Vosburgh <fubar@us.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: nikolay@redhat.com, netdev@vger.kernel.org, andy@greyhouse.net
Subject: Re: [PATCH 0/2] bonding: couple of bug fixes
Date: Tue, 11 Jun 2013 09:42:14 -0700 [thread overview]
Message-ID: <30610.1370968934@death.nxdomain> (raw)
In-Reply-To: <20130611.024530.1458814488844049119.davem@davemloft.net>
David Miller <davem@davemloft.net> wrote:
>From: nikolay@redhat.com
>Date: Thu, 6 Jun 2013 13:55:00 +0200
>
>> From: Nikolay Aleksandrov <nikolay@redhat.com>
>>
>> Hello,
>> Patch 01 resets the master's mac if the first enslave fails and the slave's
>> mac was set to the master's prior.
>> Patch 02 fixes a type bug of igmp_retrans (which is the counter of igmp_resend
>> param and was silently not working if the value was >127) so it can go up to 255
>> (as per documentation). It also fixes two tricky race conditions which were
>> hidden because of the previous bug.
>
>There was some minor back and forth between Jay and Nikolay on this set,
>but I'd like to see some ACKs before applying this stuff.
I'm fine with the code changes, although I think a description
of the three way race that Nikolay described in his last email should be
in the log message, perhaps along with a brief description of what
conditions would trigger the problem.
With the above caveat:
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
-J
---
-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com
next prev parent reply other threads:[~2013-06-11 16:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 11:55 [PATCH 0/2] bonding: couple of bug fixes nikolay
2013-06-06 11:55 ` [PATCH 1/2] bonding: reset master mac on first enslave failure nikolay
2013-06-06 11:55 ` [PATCH 2/2] bonding: fix igmp_retrans type and two related races nikolay
2013-06-07 1:00 ` Jay Vosburgh
2013-06-07 9:37 ` Nikolay Aleksandrov
2013-06-11 9:45 ` [PATCH 0/2] bonding: couple of bug fixes David Miller
2013-06-11 16:42 ` Jay Vosburgh [this message]
2013-06-11 16:50 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30610.1370968934@death.nxdomain \
--to=fubar@us.ibm.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).