From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Subject: Re: [bpf-next PATCH] net: br_vlan build error Date: Tue, 27 Mar 2018 08:57:00 -0700 Message-ID: <306fcd44-3cec-c78e-ede6-87cd6f56e01f@gmail.com> References: <20180327153859.28865.74511.stgit@john-Precision-Tower-5810> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: netdev@vger.kernel.org, davem@davemloft.net To: stephen@networkplumber.org, 3chas3@gmail.com Return-path: Received: from mail-it0-f68.google.com ([209.85.214.68]:33260 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752530AbeC0P5Q (ORCPT ); Tue, 27 Mar 2018 11:57:16 -0400 Received: by mail-it0-f68.google.com with SMTP id z143-v6so16431664itc.0 for ; Tue, 27 Mar 2018 08:57:16 -0700 (PDT) In-Reply-To: <20180327153859.28865.74511.stgit@john-Precision-Tower-5810> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 03/27/2018 08:38 AM, John Fastabend wrote: > Fix build error in br_if.c > > net/bridge/br_if.c: In function ‘br_mtu’: > net/bridge/br_if.c:458:8: error: ‘const struct net_bridge’ has no member named ‘vlan_enabled’ > if (br->vlan_enabled) > ^ > net/bridge/br_if.c:462:1: warning: control reaches end of non-void function [-Wreturn-type] > } > ^ > Fixes: 419d14af9e07f ("bridge: Allow max MTU when multiple VLANs present") > Signed-off-by: John Fastabend > --- This is against net-next sorry for any confusion. Let me know if you need me to respin. @Chas, also I only build tested this to get my kernels building again. You should probably verify I implemented what you expect in the case without vlan filtering. It seems correct to me but I'm not the expert here. Thanks, John