[PATCH 0/2] bonding:delete two unused variables

[PATCH 0/2] bonding:delete two unused variables

[Weiping Pan(潘卫平)]

I found that variable alb_timer and rlb_interval_counter in struct
alb_bond_info are not used by other codes any more, so delete them.

Weiping Pan(潘卫平) (2):
  bonding:delete unused alb_timer
  bonding:delete unused rlb_interval_counter

 drivers/net/bonding/bond_alb.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

-- 
1.7.4

[PATCH 1/2] bonding:delete unused alb_timer

[Weiping Pan(潘卫平)]

Now bonding-alb uses delayed_work instead of timer_list.

Signed-off-by: Weiping Pan(潘卫平) <panweiping3@gmail.com>
---
 drivers/net/bonding/bond_alb.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/net/bonding/bond_alb.h b/drivers/net/bonding/bond_alb.h
index 86861f0..f2a1d0a 100644
--- a/drivers/net/bonding/bond_alb.h
+++ b/drivers/net/bonding/bond_alb.h
@@ -122,7 +122,6 @@ struct tlb_slave_info {
 };
 
 struct alb_bond_info {
-	struct timer_list	alb_timer;
 	struct tlb_client_info	*tx_hashtbl; /* Dynamically allocated */
 	spinlock_t		tx_hashtbl_lock;
 	u32			unbalanced_load;
-- 
1.7.4

[PATCH 2/2] bonding:delete unused rlb_interval_counter

[Weiping Pan(潘卫平)]

Now, alb_bond_info uses rx_ntt,rlb_update_delay_counter and
rlb_update_retry_counter to decide when to call rlb_update_rx_clients().

Signed-off-by: Weiping Pan(潘卫平) <panweiping3@gmail.com>
---
 drivers/net/bonding/bond_alb.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/net/bonding/bond_alb.h b/drivers/net/bonding/bond_alb.h
index f2a1d0a..01ed1fb 100644
--- a/drivers/net/bonding/bond_alb.h
+++ b/drivers/net/bonding/bond_alb.h
@@ -139,7 +139,6 @@ struct alb_bond_info {
 	struct slave		*next_rx_slave;/* next slave to be assigned
 						* to a new rx client for
 						*/
-	u32			rlb_interval_counter;
 	u8			primary_is_promisc;	   /* boolean */
 	u32			rlb_promisc_timeout_counter;/* counts primary
 							     * promiscuity time
-- 
1.7.4

Re: [PATCH 0/2] bonding:delete two unused variables

[Jay Vosburgh]

>I found that variable alb_timer and rlb_interval_counter in struct
>alb_bond_info are not used by other codes any more, so delete them.
>
>Weiping Pan(潘卫平) (2):
>  bonding:delete unused alb_timer
>  bonding:delete unused rlb_interval_counter

	For both patches.

Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>


> drivers/net/bonding/bond_alb.h |    2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
>-- 
>1.7.4
>
>--
>To unsubscribe from this list: send the line "unsubscribe netdev" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] bonding:delete two unused variables

[David Miller]

From: Jay Vosburgh <fubar@us.ibm.com>
Date: Mon, 11 Apr 2011 12:02:09 -0700

> 
>>I found that variable alb_timer and rlb_interval_counter in struct
>>alb_bond_info are not used by other codes any more, so delete them.
>>
>>Weiping Pan(潘卫平) (2):
>>  bonding:delete unused alb_timer
>>  bonding:delete unused rlb_interval_counter
> 
> 	For both patches.
> 
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>

Applied.