From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24A47C43381 for ; Tue, 12 Mar 2019 12:27:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F2C7020657 for ; Tue, 12 Mar 2019 12:27:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726727AbfCLM1j convert rfc822-to-8bit (ORCPT ); Tue, 12 Mar 2019 08:27:39 -0400 Received: from gloria.sntech.de ([185.11.138.130]:59548 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726193AbfCLM1j (ORCPT ); Tue, 12 Mar 2019 08:27:39 -0400 Received: from we0652.dip.tu-dresden.de ([141.76.178.140] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1h3gVE-0001a0-Fk; Tue, 12 Mar 2019 13:27:28 +0100 From: Heiko Stuebner To: Andrew Lunn , david.wu@rock-chips.com, zonque@gmail.com Cc: David Miller , hkallweit1@gmail.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH net-next] net: phy: improve handling link_change_notify callback Date: Tue, 12 Mar 2019 13:27:27 +0100 Message-ID: <3079158.ITs3Wk0qno@phil> In-Reply-To: <20190304200630.GJ26378@lunn.ch> References: <411b1c33-a245-0706-8afd-c4bea1b90f68@gmail.com> <20190304.113025.1437399524067140375.davem@davemloft.net> <20190304200630.GJ26378@lunn.ch> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Andrew, Heiner, Am Montag, 4. März 2019, 21:06:30 CET schrieb Andrew Lunn: > On Mon, Mar 04, 2019 at 11:30:25AM -0800, David Miller wrote: > > From: Heiner Kallweit > > Date: Sun, 3 Mar 2019 19:58:57 +0100 > > > > > Currently the Phy driver's link_change_notify callback is called > > > whenever the state machine is run (every second if polling), no matter > > > whether the state changed or not. This isn't needed and may confuse > > > users considering the name of the callback. Therefore let's change > > > the behavior and call this callback only in case of an actual > > > state change. > > > > > > This requires changes to the at803x and rockchip drivers. > > > at803x can be simplified so that it reacts on a state change to > > > PHY_NOLINK only. > > > The rockchip driver can also be much simplified. We simply re-init > > > the AFE/DSP registers whenever we change to PHY_RUNNING and speed > > > is 100Mbps. This causes very small overhead because we do this even > > > if the speed was 100Mbps already. But this is neglectable and > > > I think justified by the much simpler code. > > > > > > Changes are compile-tested only. > > > > > > Signed-off-by: Heiner Kallweit > > > > Someone please review this. > > Hi David > > We should probably wait for a Tested-by: from Daniel Mack > and David Wu , or > equivalent. We should probably add them to the list of recipients if we want tests from them, which I've done now. @David: patch in question that changes the Rockchip eth-phy is https://patchwork.kernel.org/patch/10837217/ Sadly I don't have matching hardware to test this myself. Heiko