From: Jes Sorensen <jes.sorensen@gmail.com>
To: Chris Chiu <chiu@endlessm.com>,
kvalo@codeaurora.org, davem@davemloft.net
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux@endlessm.com
Subject: Re: [PATCH] rtl8xxxu: fix RTL8723BU connection failure issue after warm reboot
Date: Tue, 15 Oct 2019 13:47:32 -0400 [thread overview]
Message-ID: <30809d50-a9ba-881b-1d3b-f3582c14cf79@gmail.com> (raw)
In-Reply-To: <20191015101909.4640-1-chiu@endlessm.com>
On 10/15/19 6:19 AM, Chris Chiu wrote:
> The RTL8723BU has problems connecting to AP after each warm reboot.
> Sometimes it returns no scan result, and in most cases, it fails
> the authentication for unknown reason. However, it works totally
> fine after cold reboot.
>
> Compare the value of register SYS_CR and SYS_CLK_MAC_CLK_ENABLE
> for cold reboot and warm reboot, the registers imply that the MAC
> is already powered and thus some procedures are skipped during
> driver initialization. Double checked the vendor driver, it reads
> the SYS_CR and SYS_CLK_MAC_CLK_ENABLE also but doesn't skip any
> during initialization based on them. This commit only tells the
> RTL8723BU to do full initilization without checking MAC status.
>
> Signed-off-by: Chris Chiu <chiu@endlessm.com>
> ---
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 1 +
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c | 1 +
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 3 +++
> 3 files changed, 5 insertions(+)
Looks good to me! If this takes care of the warm boot problem, that's
pretty awesome.
Signed-off-by: Jes Sorensen <Jes.Sorensen@gmail.com>
Jes
next prev parent reply other threads:[~2019-10-15 17:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 10:19 [PATCH] rtl8xxxu: fix RTL8723BU connection failure issue after warm reboot Chris Chiu
2019-10-15 17:47 ` Jes Sorensen [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-10-15 10:21 Chris Chiu
2019-10-15 11:36 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30809d50-a9ba-881b-1d3b-f3582c14cf79@gmail.com \
--to=jes.sorensen@gmail.com \
--cc=chiu@endlessm.com \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).