From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91592C43381 for ; Sat, 2 Mar 2019 02:58:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5523320848 for ; Sat, 2 Mar 2019 02:58:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AvFgUxQG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727800AbfCBC65 (ORCPT ); Fri, 1 Mar 2019 21:58:57 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:37057 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727272AbfCBC65 (ORCPT ); Fri, 1 Mar 2019 21:58:57 -0500 Received: by mail-pl1-f196.google.com with SMTP id q3so12368876pll.4 for ; Fri, 01 Mar 2019 18:58:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3OPB+YyFgfpLoGXWUnEZ0X0qenC6HBiYwu+pdWiruWA=; b=AvFgUxQGaBc0qEcI3P7ntin6ePNtwu8xtBk/oJ1+jN2NWjGq+dCz3YOG9shSW/xDNj Tq8i4GNcwSXNtxGhMOA7XiyxDNGVmC0IrCzhcdY0/vVCkxCSBArcZbAOApHA8+E49mO6 zhDaHIklmBi89n5yvEQqUzK+LF6+Esm+RYcrXnCjo41S0t9IwPnMKI5HytPbBAk8w/CI NADl2JCMZgIVDh7ja57MiRBqM7/exEI6fcOvmgxaTGpuaR2sK+Y4Vw+NR15xZysEhb5w z5PLFalVsk5Hu1OyB4ZOu+/hd2ITXZhhZdwfsYsyxpPsrivxJaxntFvcEfN3kM4EEGDb VBDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=3OPB+YyFgfpLoGXWUnEZ0X0qenC6HBiYwu+pdWiruWA=; b=OddblUVXhpeWTkU0G8E0rkEvn7OFiE2JerYebG/kjYSAM/zCWqZUeKg3EVR15FhaDD xOdotuVqbMI8BG0EC3/0481FaEsN7wnUbWfo/O5RxTTiRqmyQwCH8Xu78u5ailEnKlEU ng0qPe8Ca317APd8wtYnzT/cD1tNCSodyNhIXuZpFeT0vCdY5q9ZuR5x9zol3WLmEL76 ypXD0S/i31Mx0rcZ8l9ulwYJQh1/vYDHybhWdOislXyOPOIhJJs5nnAqegkgaVNgYv2A INv6EMkKpMonSo0MmjKvVyNkpxCeaTaZxsN10vbrB+tizlHxKeoFVpnsrqeokcp0n0xh ZLvQ== X-Gm-Message-State: APjAAAUtk6NMJWSg4UCgCfsj1CVvj0wvLuAeQcsw7otq7NEUdyjweAeL qqmBIUBEz2jgOzgXsF1YRh4= X-Google-Smtp-Source: APXvYqyGhBOhqvPdf9EooYQ6eQtesu32mtae5fWeS7g1RQ932auKf/qmN0REDrpC7LjWg3eEZGcHUw== X-Received: by 2002:a17:902:9304:: with SMTP id bc4mr9046464plb.81.1551495535964; Fri, 01 Mar 2019 18:58:55 -0800 (PST) Received: from [10.230.26.115] ([192.19.224.250]) by smtp.gmail.com with ESMTPSA id y9sm17604227pfn.120.2019.03.01.18.58.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Mar 2019 18:58:55 -0800 (PST) Subject: Re: [patch net-next RFC 0/8] net: expose switch ID via devlink To: Jiri Pirko , netdev@vger.kernel.org Cc: davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, dirk.vandermerwe@netronome.com, andrew@lunn.ch, vivien.didelot@gmail.com References: <20190301160542.6474-1-jiri@resnulli.us> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; keydata= mQENBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAG0KEZsb3JpYW4gRmFpbmVsbGkgPGZhaW5lbGxpQGJyb2FkY29tLmNvbT6JAccEEAECALEF AlPAG9YXCgABv0jL/n0t8VEFmtDa8j7qERo7AN0gFAAAAAAAFgABa2V5LXVzYWdlLW1hc2tA cGdwLmNvbY4wFIAAAAAAIAAHcHJlZmVycmVkLWVtYWlsLWVuY29kaW5nQHBncC5jb21wZ3Bt aW1lCAsJCAcDAgEKAhkBBReAAAAAGRhsZGFwOi8va2V5cy5icm9hZGNvbS5jb20FGwMAAAAD FgIBBR4BAAAABBUICQoACgkQgTG1xCm8ZqD+Dgf9HhhzqvJYIPomNeg+ll7/TbzWb871E+HQ TaufJQFQwLEbgdFSZO2uj4UqfDpCyTwtHTVMJogWt3pCAE1sadeIY8OlT6918ofKIl8AiHj2 BlfL7ASZ5wzkRMt/4TZoinq9O1tPEynb5G6PdZTV3UQtmSGnpt2EOu7KtRJsnThBiXoOO9TJ Asg4vXJ0ZM1y/MPhQlZbPCHQZFe1gaVWBPLGnLyWyeprqgSLWHaGqrUhlfK1sLuJK1bjYDCI NetK0pS4cA4ZJgogr5FrtV64R19zLl02mt/Yj7rAmjC3ZBuwVi3V35kD8Kd4d9QM2apsiILV bzGbtVCSUgvxI+1SsJEm3bkBDQRTwBvBAQgArGvvWip77T4xgJztZp9YRylAcVTC9gtx0Gg6 eYk/EPANGm9TkuGpI++T/Il2H2TjFQNC7eubWohbYj0+6Tmf8nP+VmyobDxPXcMrK7x4xy9o D+Kub2Vf0SXbsM8fL/SqzGbFWZSm73L1L4GZoxvYIz0i7LExYSX2u5YVLaMBaH9HwKt2cvr7 MuTrRHtcbOZImoXT29g2UnoF1uwxYNeRhZY/lRvVkkY0lDipPuDwg3SpfHMtCybPq1uAswQd gEbHzRsEXwCR1OF3pIuGt4I3tSEhH/k1caqi0BlqjbGUOkku44xC2gf1ZU267FBBkdV3yJ/7 KnrJEnkMCYhS3kII9wARAQABiQJBBBgBAgErBQJTwBvCBRsMAAAAwF0gBBkBCAAGBQJTwBvB AAoJEJNgBqiYLw9VDRUIAJaTef6hsUAESnlGDpC+ymL2RZdzAJx9lXjU4hhaFcyhznuyyMJq d3mehmLxsqDRvHDiqyD71w2Bnc838MVZw0pwBPdnb/h9Ocmp0lL/9hwSGWvy4az5lYVyoA9u 14UIzh0YNGu6jr0isd/LJAbHXqwJwWWs3y8PTrpEp68V6lv+aXt5gR03lJEAvIR1Awp4JJ/e Z5y12gQISp0X8xal9YhhDWER92YLYrO2b6Hc2S31lAupzfCw8lmZsP1PRz1GmF/KmDD9J9N/ b8IehhWQqrBQjMjn2K2XkvN75HnAMHKFYfHZR3ZHtK52ZP1crV7THtbtrnPXVDq+vO4QPmdC +SEACgkQgTG1xCm8ZqC6BwgAl3kRh7oozpjpG8jpO8en5CBtTl3G+OpKJK9qbQyzdCsuJ0K1 qe1wZPZbP/Y+VtmqSgnExBzjStt9drjFBK8liPQZalp2sMlS9S7csSy6cMLF1auZubAZEqpm tpXagbtgR12YOo57Reb83F5KhtwwiWdoTpXRTx/nM0cHtjjrImONhP8OzVMmjem/B68NY++/ qt0F5XTsP2zjd+tRLrFh3W4XEcLt1lhYmNmbJR/l6+vVbWAKDAtcbQ8SL2feqbPWV6VDyVKh ya/EEq0xtf84qEB+4/+IjCdOzDD3kDZJo+JBkDnU3LBXw4WCw3QhOXY+VnhOn2EcREN7qdAK w0j9Sw== Message-ID: <30836fe5-b048-0f1a-acd0-b2f718acc24c@gmail.com> Date: Fri, 1 Mar 2019 18:58:52 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.2 MIME-Version: 1.0 In-Reply-To: <20190301160542.6474-1-jiri@resnulli.us> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3/1/2019 8:05 AM, Jiri Pirko wrote: > From: Jiri Pirko > > To provide visibility of the ports, as discussed this week, this > patchset exposes switch ID for devlink ports, which are part of a > switch. The rest of the ports if any (in case of sr-iov for example) > do not set switch ID. > > Note that I send this as RFC because I don't have the NFP bits correct. > The switch ID should be only set for the eswitch ports (representors). > Jakub, could you please help with this? > > As a follow-up I also plan to add devlink_port_attrs_set to all users > of ndo_get_port_parent_id and ndo_get_phys_port_name and remove these > ndos completely. But that also depends on Jakub's patchset which > introduces PF and VF port flavours. Some comments in specific patches, but overall this looks great to me, thanks Jiri! > > Jiri Pirko (8): > net: devlink: convert devlink_port_attrs bools to bits > net: devlink: extend port attrs for switch ID > net: devlink: introduce devlink_compat_switch_id_get() helper > mlxsw: Pass switch ID through devlink_port_attrs_set() > mlxsw: Remove ndo_get_port_parent_id implementation > nfp: pass switch ID through devlink_port_attrs_set() > nfp: register devlink port before netdev > nfp: remove ndo_get_port_parent_id implementation > > drivers/net/ethernet/mellanox/mlxsw/core.c | 7 ++- > drivers/net/ethernet/mellanox/mlxsw/core.h | 4 +- > drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 17 ++----- > drivers/net/ethernet/mellanox/mlxsw/switchx2.c | 16 +------ > drivers/net/ethernet/netronome/nfp/nfp_devlink.c | 6 ++- > .../net/ethernet/netronome/nfp/nfp_net_common.c | 1 - > drivers/net/ethernet/netronome/nfp/nfp_net_main.c | 27 ++++++----- > drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 1 - > drivers/net/ethernet/netronome/nfp/nfp_port.c | 16 ------- > include/net/devlink.h | 23 +++++++-- > include/uapi/linux/devlink.h | 2 + > net/core/dev.c | 8 +++- > net/core/devlink.c | 54 +++++++++++++++++++--- > net/dsa/dsa2.c | 6 +-- > 14 files changed, 109 insertions(+), 79 deletions(-) > -- Florian