Re: [PATCH iproute2-next] tc/police: Allow 64 bit burst size

[Jay Vosburgh <jay.vosburgh@canonical.com>]

David Ahern <dsahern@gmail.com> wrote:

>On 9/9/25 9:32 PM, Jamal Hadi Salim wrote:
>> 
>> Please run tdc tests. David/Stephen - can we please make this a
>> requirement for iproute2 tc related changes?
>
>I will try to remember to run tdc tests for tc patches. Without an
>automated setup, there will be misses over time.
>
>> 
>> Jay, your patches fail at least one test because you changed the unit outputs.
>> Either we fix the tdc test or you make your changes backward compatible.
>> In the future also cc kernel tc maintainers (I only saw this because
>> someone pointed it to me).
>> Overall the changes look fine.
>
>Sent a patch to add a tc entry to iproute2 maintainers file.
>
>You say the change looks fine but at least one test fails meaning
>changes are requested?

	Yes, I ran the tests and saw one failure, in the following:

        "cmdUnderTest": "$TC actions add action police pkts_rate 1000 pkts_burst
 200 index 1",
        "expExitCode": "0",
        "verifyCmd": "$TC actions ls action police",
        "matchPattern": "action order [0-9]*:  police 0x1 rate 0bit burst 0b mtu 4096Mb pkts_rate 1000 pkts_burst 200",

	Which is trying to match a returned mtu value of "4096Mb" but
the new code prints "4Gb"; should be straightforward to change the test
to accept either returned value.

	Or I can take out the bit that prints sufficiently large values
in units of Gb, if you've got a preference for leaving that part alone.
Doing so would ease the lockstep problem between the tests in the kernel
tree and the change in iproute2.  The numeric formatting isn't the
important part of the patch set, so I'm ok either way.

	-J

---
	-Jay Vosburgh, jay.vosburgh@canonical.com