From: Heiner Kallweit <hkallweit1@gmail.com>
To: Petr Tesarik <ptesarik@suse.cz>
Cc: Realtek linux nic maintainers <nic_swsd@realtek.com>,
netdev@vger.kernel.org
Subject: Re: RTL8402 stops working after hibernate/resume
Date: Fri, 25 Sep 2020 16:47:54 +0200 [thread overview]
Message-ID: <30969885-9611-06d8-d50a-577897fcab29@gmail.com> (raw)
In-Reply-To: <20200925145608.66a89e73@ezekiel.suse.cz>
On 25.09.2020 14:56, Petr Tesarik wrote:
> On Fri, 25 Sep 2020 11:52:41 +0200
> Petr Tesarik <ptesarik@suse.cz> wrote:
>
>> On Fri, 25 Sep 2020 11:44:09 +0200
>> Heiner Kallweit <hkallweit1@gmail.com> wrote:
>>
>>> On 25.09.2020 10:54, Petr Tesarik wrote:
>> [...]
>>>> Does it make sense to bisect the change that broke the driver for me, or should I rather dispose of this waste^Wlaptop in an environmentally friendly manner? I mean, would you eventually accept a workaround for a few machines with a broken BIOS?
>>>>
>>> If the workaround is small and there's little chance to break other stuff: then usually yes.
>>> If you can spend the effort to bisect the issue, this would be appreciated.
>>
>> OK, then I'm going to give it a try.
>
> Done. The system freezes when this commit is applied:
>
> commit 9f0b54cd167219266bd3864570ae8f4987b57520
> Author: Heiner Kallweit <hkallweit1@gmail.com>
> Date: Wed Jun 17 22:55:40 2020 +0200
>
> r8169: move switching optional clock on/off to pll power functions
>
This sounds weird. On your system tp->clk should be NULL, making
clk_prepare_enable() et al no-ops. Please check whether tp->clk
is NULL after the call to rtl_get_ether_clk().
> Relevant chip clocks are disabled in rtl_pll_power_down(), therefore
> move calling clk_disable_unprepare() there. Similar for enabling the
> clock.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> I cannot be sure this is related to the malfunction after resume reported earlier, but it again touches the suspend/resume path...
>
> Anything else I should try?
>
> Petr T
>
next prev parent reply other threads:[~2020-09-25 14:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 8:28 RTL8402 stops working after hibernate/resume Petr Tesarik
2020-07-15 15:22 ` Heiner Kallweit
2020-07-16 8:58 ` Petr Tesarik
2020-07-18 12:07 ` Heiner Kallweit
2020-09-03 8:41 ` Petr Tesarik
2020-09-17 14:10 ` Petr Tesarik
2020-09-23 9:57 ` Heiner Kallweit
2020-09-24 19:14 ` Petr Tesarik
2020-09-24 19:37 ` Heiner Kallweit
2020-09-24 20:12 ` Heiner Kallweit
2020-09-25 7:30 ` Petr Tesarik
2020-09-25 8:54 ` Petr Tesarik
2020-09-25 9:44 ` Heiner Kallweit
2020-09-25 9:52 ` Petr Tesarik
2020-09-25 12:56 ` Petr Tesarik
2020-09-25 14:47 ` Heiner Kallweit [this message]
2020-09-29 19:07 ` Petr Tesarik
2020-09-29 19:41 ` Heiner Kallweit
2020-09-29 20:08 ` Hans de Goede
2020-09-29 20:29 ` Hans de Goede
2020-09-29 20:35 ` Heiner Kallweit
2020-09-29 20:42 ` Heiner Kallweit
2020-09-30 9:04 ` Hans de Goede
2020-09-30 15:47 ` Heiner Kallweit
2020-09-30 16:41 ` Petr Tesarik
2020-09-30 17:13 ` Heiner Kallweit
2020-09-30 17:32 ` Petr Tesarik
2020-09-30 18:00 ` Petr Tesarik
2020-09-30 20:11 ` Heiner Kallweit
2020-09-30 21:44 ` Petr Tesarik
2020-10-01 6:14 ` Heiner Kallweit
2020-09-30 18:10 ` Petr Tesarik
2020-09-29 21:17 ` Petr Tesarik
2020-07-15 15:25 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30969885-9611-06d8-d50a-577897fcab29@gmail.com \
--to=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=ptesarik@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).