From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D3C62EF64F; Wed, 8 Jul 2026 15:42:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783525373; cv=none; b=o+RfKLDX1XHpFm/gNJy6NYGlNLzo8C1OeTk/fVCyKY+XdxtBtg0Bh7XKVK24+ScrM7jc7iwQBZ72QYjzw/xhXd11+qnWF7tv8bciNZZi/cxHBFEIy+Ai9V4dV5LkfWmJ+nmB/Sy4fVZUP4UnayGKGDPNKIROoZ9A2/netEahpGo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783525373; c=relaxed/simple; bh=n5q1N+F+EtpYBlqFVelOGH+V9eik0CiVbOF5G+JRUlM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FRX4niv+XfgWF2x5IDpOlwappKiyBRQYIgdudL/ktB85LlFWZl7FntNMQ4kypV3vPWk3pCDWWTTX59vtIHziaxf1OkLFFVHlZ1lYFMejMLHrN2qLQ7t+gkwEHWePdtq6RBUIoI0hvcdzJFLdDtlVaA2O3WMNR2/0VVa69li8sg4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BuL7Jx1L; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BuL7Jx1L" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCD101F000E9; Wed, 8 Jul 2026 15:42:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783525372; bh=myM5TVBym+J7VoDATrItCwAsgA0Kf6ZymjUmGE93LlM=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=BuL7Jx1LxY/yiPjkgDR5OPXH+zWsx1gCpMmVvDa62XvKL3f/pa2LOUXUpzoCrRrM4 JfU1OapOnmLmQbIwJb56euDRGCCX0qi+Av9zT5xlOm0WAVYz46fMXkOaU5RU4dyigc Ij8GZFAWl2LRefEMfBzPwq+XkdUWn20WAl9F80i5QKGIEZ7Neiph9yvXoR9HhpZfWl 7naZmxb/abWJQRFznl4PsCW5R+NwoA9UQn/yfZrzZDFdpSYHqp/YXd3qwESsg4VfHR FkMTksjQNsarrGDTcgfwwtRpYgi+maKBGk6QcGxuQCF9blUyHwPcH6OqtlrlNxIwg2 YE60v2Ix4lAzQ== Message-ID: <309e7b6b-c5a0-4404-97a9-72de45e507ff@kernel.org> Date: Wed, 8 Jul 2026 09:42:51 -0600 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] net: ipip: use tunnel parameters for fill_forward_path route lookup Content-Language: en-US To: Lorenzo Bianconi , Ido Schimmel , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Pablo Neira Ayuso , Florian Westphal Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org References: <20260708-ipip-route-lookup-fill_forward_path-v1-1-b77df74822ed@kernel.org> From: David Ahern In-Reply-To: <20260708-ipip-route-lookup-fill_forward_path-v1-1-b77df74822ed@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/8/26 5:25 AM, Lorenzo Bianconi wrote: > Pass source address, DSCP and output interface from the tunnel > configuration to ip_route_output() in ipip_fill_forward_path(), aligning > the route lookup with the slow path in ipip_tunnel_xmit(). > > Signed-off-by: Lorenzo Bianconi > --- > net/ipv4/ipip.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/net/ipv4/ipip.c b/net/ipv4/ipip.c > index b643194f57d2..d1aa048a6099 100644 > --- a/net/ipv4/ipip.c > +++ b/net/ipv4/ipip.c > @@ -360,8 +360,9 @@ static int ipip_fill_forward_path(struct net_device_path_ctx *ctx, > const struct iphdr *tiph = &tunnel->parms.iph; > struct rtable *rt; > > - rt = ip_route_output(dev_net(ctx->dev), tiph->daddr, 0, 0, 0, > - RT_SCOPE_UNIVERSE); > + rt = ip_route_output(dev_net(ctx->dev), tiph->daddr, tiph->saddr, > + inet_dsfield_to_dscp(tiph->tos), > + tunnel->parms.link, RT_SCOPE_UNIVERSE); > if (IS_ERR(rt)) > return PTR_ERR(rt); > > > --- > base-commit: 155c68aef2397f8c5d72ef10acf48ae159bf1869 > change-id: 20260708-ipip-route-lookup-fill_forward_path-6a8a1f45084c > > Best regards, Reviewed-by: David Ahern