From: Florian Fainelli <f.fainelli@gmail.com>
To: Kun Yi <kunyi@google.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org, Avi.Fishman@nuvoton.com,
tali.perry@nuvoton.com, tomer.maimon@nuvoton.com,
benjaminfair@google.com, rlippert@google.com
Subject: Re: [PATCH net-next] net: phy: broadcom: Enable 125 MHz clock on LED4 pin for BCM54612E by default.
Date: Mon, 4 Jun 2018 18:45:54 -0700 [thread overview]
Message-ID: <30ae8a0a-936a-ab34-a23e-ecb755e4b787@gmail.com> (raw)
In-Reply-To: <20180604201704.238472-1-kunyi@google.com>
Le 06/04/18 à 13:17, Kun Yi a écrit :
> BCM54612E have 4 multi-functional LED pins that can be configured
> through register setting; the LED4 pin can be configured to a 125MHz
> reference clock output by setting the spare register. Since the dedicated
> CLK125 reference clock pin is not brought out on the 48-Pin MLP, the LED4
> pin is the only pin to provide such function in this package, and therefore
> it is beneficial to just enable the reference clock by default.
Checked the data sheet and this appears to be absolutely correct:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2018-06-05 1:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 20:17 [PATCH net-next] net: phy: broadcom: Enable 125 MHz clock on LED4 pin for BCM54612E by default Kun Yi
2018-06-05 1:45 ` Florian Fainelli [this message]
2018-06-05 13:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30ae8a0a-936a-ab34-a23e-ecb755e4b787@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Avi.Fishman@nuvoton.com \
--cc=benjaminfair@google.com \
--cc=davem@davemloft.net \
--cc=kunyi@google.com \
--cc=netdev@vger.kernel.org \
--cc=rlippert@google.com \
--cc=tali.perry@nuvoton.com \
--cc=tomer.maimon@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).