From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net-next] net: phy: broadcom: Enable 125 MHz clock on LED4 pin for BCM54612E by default. Date: Mon, 4 Jun 2018 18:45:54 -0700 Message-ID: <30ae8a0a-936a-ab34-a23e-ecb755e4b787@gmail.com> References: <20180604201704.238472-1-kunyi@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: netdev@vger.kernel.org, Avi.Fishman@nuvoton.com, tali.perry@nuvoton.com, tomer.maimon@nuvoton.com, benjaminfair@google.com, rlippert@google.com To: Kun Yi , davem@davemloft.net Return-path: Received: from mail-ot0-f195.google.com ([74.125.82.195]:41598 "EHLO mail-ot0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751206AbeFEBp7 (ORCPT ); Mon, 4 Jun 2018 21:45:59 -0400 Received: by mail-ot0-f195.google.com with SMTP id t1-v6so816955oth.8 for ; Mon, 04 Jun 2018 18:45:58 -0700 (PDT) In-Reply-To: <20180604201704.238472-1-kunyi@google.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Le 06/04/18 à 13:17, Kun Yi a écrit : > BCM54612E have 4 multi-functional LED pins that can be configured > through register setting; the LED4 pin can be configured to a 125MHz > reference clock output by setting the spare register. Since the dedicated > CLK125 reference clock pin is not brought out on the 48-Pin MLP, the LED4 > pin is the only pin to provide such function in this package, and therefore > it is beneficial to just enable the reference clock by default. Checked the data sheet and this appears to be absolutely correct: Reviewed-by: Florian Fainelli -- Florian