From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nambiar, Amritha" Subject: Re: [PATCH 6/6] [net-next]net: i40e: Enable cloud filters in i40e via tc/flower classifier Date: Tue, 1 Aug 2017 19:13:45 -0700 Message-ID: <30cd59b5-4175-8641-f288-a2373475837d@intel.com> References: <150154569340.4135.11548126443780491627.stgit@anamdev.jf.intel.com> <150154788503.4135.7051219373661945937.stgit@anamdev.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: alexander.h.duyck@intel.com, kiran.patil@intel.com, netdev@vger.kernel.org, mitch.a.williams@intel.com, alexander.duyck@gmail.com, neerav.parikh@intel.com, sridhar.samudrala@intel.com, carolyn.wyborny@intel.com, Or Gerlitz To: Jamal Hadi Salim , intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com Return-path: Received: from mga11.intel.com ([192.55.52.93]:13963 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751817AbdHBCNq (ORCPT ); Tue, 1 Aug 2017 22:13:46 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On 8/1/2017 3:56 AM, Jamal Hadi Salim wrote: > On 17-07-31 08:38 PM, Amritha Nambiar wrote: >> This patch enables tc-flower based hardware offloads. tc/flower >> filter provided by the kernel is configured as driver specific >> cloud filter. The patch implements functions and admin queue >> commands needed to support cloud filters in the driver and >> adds cloud filters to configure these tc-flower filters. >> >> The only action supported is to redirect packets to a traffic class >> on the same device. >> >> # tc qdisc add dev eth0 ingress >> # ethtool -K eth0 hw-tc-offload on >> >> # tc filter add dev eth0 protocol ip parent ffff:\ >> prio 1 flower dst_mac 3c:fd:fe:a0:d6:70 skip_sw indev eth0\ >> action mirred ingress redirect dev eth0 tc 0 >> > > Out of curiosity - did you need to say "indev eth0" there? It looks like I don't need to specify "indev eth0". I will need to look up how this part is offloaded and probably validate in the driver when this is specified. > Also: Is it possible to add an skbmark? Example something like > these that directs two flows to the same queue but different > skb marks: > > # tc filter add dev eth0 protocol ip parent ffff: \ > prio 2 flower dst_ip 192.168.3.5/32 \ > ip_proto udp dst_port 2a skip_sw \ > action skbedit mark 11 \ > action mirred ingress redirect dev eth0 tcqueue 1 > > # tc filter add dev eth0 protocol ip parent ffff: \ > prio 1 flower dst_mac 3c:fd:fe:a0:d6:70 skip_sw \ > action skbedit mark 12 \ > action mirred ingress redirect dev eth0 tcqueue 1 > It is possible to support the skbedit mark action for the first rule here (L3 and L4) which I can take up in a subsequent patch, but this cannot be supported on our device for L2 based match in the second rule. > cheers, > jamal >