From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D83D8C3A59B for ; Fri, 30 Aug 2019 14:09:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC0932341B for ; Fri, 30 Aug 2019 14:09:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567174176; bh=p5AjW3xVDRxCRokQLJsTqv+1lmdRB2z4uTAo1OGwa4Q=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=WmJ2DzRbLs5CFV7S4V4Odmo6Uf12MQxUxM5kZGOYdKyJq5PmO1nJfJ7ve+YQ0UUN1 EGLYTT6BQX/DQGQPNRz2sXhPFdb8ejp3jEgdusT1En6idPXMinm8wjULQryBU5Z4w5 GJ5WjMkxJCJU5+qTsMPnfMghVZToL+/DE04K/tTU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728021AbfH3OJc (ORCPT ); Fri, 30 Aug 2019 10:09:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:46668 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727791AbfH3OJb (ORCPT ); Fri, 30 Aug 2019 10:09:31 -0400 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 96DBD22CE9; Fri, 30 Aug 2019 14:09:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567174170; bh=p5AjW3xVDRxCRokQLJsTqv+1lmdRB2z4uTAo1OGwa4Q=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=E/heTaWMHie+f9aeljhO/1yfl9cSU7vcNF/AqUhGNPWL/KPpd7dNvx0UyWaxDk1k2 VFXySM1rPovDrqpfURtsc0Qw49mjuDC3qFcbeYuFqQRddu0yUujxGnbUUQ6uBdz0AY Fg6wPEqFXmdOf/n5IqZABnc7lopIyAgMoMkspmt4= Subject: Re: [PATCH] seccomp: fix compilation errors in seccomp-bpf kselftest To: Alakesh Haloi , Kees Cook , Andy Lutomirski , Will Drewry , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song Cc: linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, shuah References: <20190822215823.GA11292@ip-172-31-44-144.us-west-2.compute.internal> From: shuah Message-ID: <30e993fe-de76-9831-7ecc-61fcbcd51ae0@kernel.org> Date: Fri, 30 Aug 2019 08:09:20 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190822215823.GA11292@ip-172-31-44-144.us-west-2.compute.internal> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 8/22/19 3:58 PM, Alakesh Haloi wrote: > Without this patch we see following error while building and kselftest > for secccomp_bpf fails. > > seccomp_bpf.c:1787:20: error: ‘PTRACE_EVENTMSG_SYSCALL_ENTRY’ undeclared (first use in this function); > seccomp_bpf.c:1788:6: error: ‘PTRACE_EVENTMSG_SYSCALL_EXIT’ undeclared (first use in this function); > > Signed-off-by: Alakesh Haloi > --- > tools/testing/selftests/seccomp/seccomp_bpf.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c > index 6ef7f16c4cf5..2e619760fc3e 100644 > --- a/tools/testing/selftests/seccomp/seccomp_bpf.c > +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c > @@ -1353,6 +1353,14 @@ TEST_F(precedence, log_is_fifth_in_any_order) > #define PTRACE_EVENT_SECCOMP 7 > #endif > > +#ifndef PTRACE_EVENTMSG_SYSCALL_ENTRY > +#define PTRACE_EVENTMSG_SYSCALL_ENTRY 1 > +#endif > + > +#ifndef PTRACE_EVENTMSG_SYSCALL_EXIT > +#define PTRACE_EVENTMSG_SYSCALL_EXIT 2 > +#endif > + > #define IS_SECCOMP_EVENT(status) ((status >> 16) == PTRACE_EVENT_SECCOMP) > bool tracer_running; > void tracer_stop(int sig) > Hi Kees, Okay to apply this one for 5.4-rc1. Or is this going through bpf tree? If it is going through bpf tree: Acked-by: Shuah Khan thanks, -- Shuah