[PATCH net-next] eth: bnxt: make sure we populate the qcfg defaults on old FW/HW

[PATCH net-next] eth: bnxt: make sure we populate the qcfg defaults on old FW/HW

[Jakub Kicinski]

The driver now depends on the core to tell it what the rx page size
should be for the agg ring. We must populate the ndo_default_qcfg
callback even if we don't support any queue ops.

This fixes:
  Oops: divide error: 0000 [#1] SMP DEBUG_PAGEALLOC KASAN
  RIP: 0010:bnxt_alloc_rx_page_pool (drivers/net/ethernet/broadcom/bnxt/bnxt.c:3852)

with fw version 225.1.109.0.

Link: https://lore.kernel.org/20250421222827.283737-20-kuba@kernel.org
Fixes: f96e1b35779e ("eth: bnxt: support qcfg provided rx page size")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: michael.chan@broadcom.com
CC: pavan.chebbi@broadcom.com
CC: asml.silence@gmail.com
---
 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 8fc0720c3057..466e0fc6141f 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -16316,6 +16316,7 @@ static const struct netdev_queue_mgmt_ops bnxt_queue_mgmt_ops = {
 };
 
 static const struct netdev_queue_mgmt_ops bnxt_queue_mgmt_ops_unsupp = {
+	.ndo_default_qcfg	= bnxt_queue_default_qcfg,
 };
 
 static void bnxt_remove_one(struct pci_dev *pdev)
-- 
2.52.0

Re: [PATCH net-next] eth: bnxt: make sure we populate the qcfg defaults on old FW/HW

[Jakub Kicinski]

On Wed, 28 Jan 2026 11:32:58 -0800 Jakub Kicinski wrote:
> The driver now depends on the core to tell it what the rx page size
> should be for the agg ring. We must populate the ndo_default_qcfg
> callback even if we don't support any queue ops.
> 
> This fixes:
>   Oops: divide error: 0000 [#1] SMP DEBUG_PAGEALLOC KASAN
>   RIP: 0010:bnxt_alloc_rx_page_pool (drivers/net/ethernet/broadcom/bnxt/bnxt.c:3852)
> 
> with fw version 225.1.109.0.
> 
> Link: https://lore.kernel.org/20250421222827.283737-20-kuba@kernel.org
> Fixes: f96e1b35779e ("eth: bnxt: support qcfg provided rx page size")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Can I get an ack here? This prevents machines from booting so
it'd be great to fix before too many people waste their time.

> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index 8fc0720c3057..466e0fc6141f 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -16316,6 +16316,7 @@ static const struct netdev_queue_mgmt_ops bnxt_queue_mgmt_ops = {
>  };
>  
>  static const struct netdev_queue_mgmt_ops bnxt_queue_mgmt_ops_unsupp = {
> +	.ndo_default_qcfg	= bnxt_queue_default_qcfg,
>  };
>  
>  static void bnxt_remove_one(struct pci_dev *pdev)

Re: [PATCH net-next] eth: bnxt: make sure we populate the qcfg defaults on old FW/HW

[Michael Chan]

[-- Attachment #1: Type: text/plain, Size: 985 bytes --]

On Thu, Jan 29, 2026 at 6:23 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Wed, 28 Jan 2026 11:32:58 -0800 Jakub Kicinski wrote:
> > The driver now depends on the core to tell it what the rx page size
> > should be for the agg ring. We must populate the ndo_default_qcfg
> > callback even if we don't support any queue ops.
> >
> > This fixes:
> >   Oops: divide error: 0000 [#1] SMP DEBUG_PAGEALLOC KASAN
> >   RIP: 0010:bnxt_alloc_rx_page_pool (drivers/net/ethernet/broadcom/bnxt/bnxt.c:3852)
> >
> > with fw version 225.1.109.0.
> >
> > Link: https://lore.kernel.org/20250421222827.283737-20-kuba@kernel.org
> > Fixes: f96e1b35779e ("eth: bnxt: support qcfg provided rx page size")
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>
> Can I get an ack here? This prevents machines from booting so
> it'd be great to fix before too many people waste their time.

Yes, it looks good to me.  Thanks.
Reviewed-by: Michael Chan <michael.chan@broadcom.com>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5469 bytes --]

Re: [PATCH net-next] eth: bnxt: make sure we populate the qcfg defaults on old FW/HW

[Jakub Kicinski]

On Thu, 29 Jan 2026 18:36:07 -0800 Michael Chan wrote:
> On Thu, Jan 29, 2026 at 6:23 PM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > On Wed, 28 Jan 2026 11:32:58 -0800 Jakub Kicinski wrote:  
> > > The driver now depends on the core to tell it what the rx page size
> > > should be for the agg ring. We must populate the ndo_default_qcfg
> > > callback even if we don't support any queue ops.
> > >
> > > This fixes:
> > >   Oops: divide error: 0000 [#1] SMP DEBUG_PAGEALLOC KASAN
> > >   RIP: 0010:bnxt_alloc_rx_page_pool (drivers/net/ethernet/broadcom/bnxt/bnxt.c:3852)
> > >
> > > with fw version 225.1.109.0.
> > >
> > > Link: https://lore.kernel.org/20250421222827.283737-20-kuba@kernel.org
> > > Fixes: f96e1b35779e ("eth: bnxt: support qcfg provided rx page size")
> > > Signed-off-by: Jakub Kicinski <kuba@kernel.org>  
> >
> > Can I get an ack here? This prevents machines from booting so
> > it'd be great to fix before too many people waste their time.  
> 
> Yes, it looks good to me.  Thanks.
> Reviewed-by: Michael Chan <michael.chan@broadcom.com>

Thank you!

Re: [PATCH net-next] eth: bnxt: make sure we populate the qcfg defaults on old FW/HW

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 28 Jan 2026 11:32:58 -0800 you wrote:
> The driver now depends on the core to tell it what the rx page size
> should be for the agg ring. We must populate the ndo_default_qcfg
> callback even if we don't support any queue ops.
> 
> This fixes:
>   Oops: divide error: 0000 [#1] SMP DEBUG_PAGEALLOC KASAN
>   RIP: 0010:bnxt_alloc_rx_page_pool (drivers/net/ethernet/broadcom/bnxt/bnxt.c:3852)
> 
> [...]

Here is the summary with links:
  - [net-next] eth: bnxt: make sure we populate the qcfg defaults on old FW/HW
    https://git.kernel.org/netdev/net-next/c/3cf48c04966e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH net-next] eth: bnxt: make sure we populate the qcfg defaults on old FW/HW

[Pavel Begunkov]

On 1/28/26 19:32, Jakub Kicinski wrote:
> The driver now depends on the core to tell it what the rx page size
> should be for the agg ring. We must populate the ndo_default_qcfg
> callback even if we don't support any queue ops.
> 
> This fixes:
>    Oops: divide error: 0000 [#1] SMP DEBUG_PAGEALLOC KASAN
>    RIP: 0010:bnxt_alloc_rx_page_pool (drivers/net/ethernet/broadcom/bnxt/bnxt.c:3852)
> 
> with fw version 225.1.109.0.

fwiw, looks good, thanks for the fix

Reviewed-by: Pavel Begunkov <asml.silence@gmail.com>

-- 
Pavel Begunkov