From: David Ahern <dsahern@gmail.com>
To: Roopa Prabhu <roopa@cumulusnetworks.com>,
David Ahern <dsahern@kernel.org>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH iproute2-next 5/9] libnetlink: Add helper to create nexthop dump request
Date: Thu, 30 May 2019 13:59:27 -0600 [thread overview]
Message-ID: <30fa885d-67a7-e04d-3f17-07b7cdc599f7@gmail.com> (raw)
In-Reply-To: <CAJieiUjM5-4up5RU5KV=yJALH67+MReqBZ2DymoeDz0YzNN=dA@mail.gmail.com>
On 5/30/19 1:56 PM, Roopa Prabhu wrote:
>> diff --git a/lib/libnetlink.c b/lib/libnetlink.c
>> index eb85bbdf01ee..c1cdda3b8d4e 100644
>> --- a/lib/libnetlink.c
>> +++ b/lib/libnetlink.c
>> @@ -25,6 +25,7 @@
>> #include <linux/fib_rules.h>
>> #include <linux/if_addrlabel.h>
>> #include <linux/if_bridge.h>
>> +#include <linux/nexthop.h>
>>
>> #include "libnetlink.h"
>>
>> @@ -252,6 +253,32 @@ int rtnl_open(struct rtnl_handle *rth, unsigned int subscriptions)
>> return rtnl_open_byproto(rth, subscriptions, NETLINK_ROUTE);
>> }
>>
>> +int rtnl_nexthopdump_req(struct rtnl_handle *rth, int family,
>> + req_filter_fn_t filter_fn)
>> +{
>> + struct {
>> + struct nlmsghdr nlh;
>> + struct nhmsg nhm;
>> + char buf[128];
>> + } req = {
>> + .nlh.nlmsg_len = NLMSG_LENGTH(sizeof(struct ifaddrmsg)),
>
> sizeof(struct nhmsg) ?
>
good catch. fixed.
next prev parent reply other threads:[~2019-05-30 19:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 3:17 [PATCH iproute2-next 0/9] ip: Add support for nexthop objects David Ahern
2019-05-30 3:17 ` [PATCH iproute2-next 1/9] libnetlink: Set NLA_F_NESTED in rta_nest David Ahern
2019-05-30 17:43 ` Stephen Hemminger
2019-05-30 17:50 ` David Ahern
2019-05-31 6:35 ` Michal Kubecek
2019-05-30 3:17 ` [PATCH iproute2-next 2/9] lwtunnel: Pass encap and encap_type attributes to lwt_parse_encap David Ahern
2019-05-30 3:17 ` [PATCH iproute2-next 3/9] libnetlink: Add helper to add a group via setsockopt David Ahern
2019-05-30 3:17 ` [PATCH iproute2-next 4/9] uapi: Import nexthop object API David Ahern
2019-05-30 3:17 ` [PATCH iproute2-next 5/9] libnetlink: Add helper to create nexthop dump request David Ahern
2019-05-30 19:56 ` Roopa Prabhu
2019-05-30 19:59 ` David Ahern [this message]
2019-05-30 3:17 ` [PATCH iproute2-next 6/9] ip route: Export print_rt_flags and print_rta_if David Ahern
2019-05-30 3:17 ` [PATCH iproute2-next 7/9] Add support for nexthop objects David Ahern
2019-05-30 17:45 ` Stephen Hemminger
2019-05-30 17:52 ` David Ahern
2019-05-30 17:45 ` Stephen Hemminger
2019-05-30 17:52 ` David Ahern
2019-05-30 17:52 ` Stephen Hemminger
2019-05-30 17:55 ` David Ahern
2019-05-30 20:01 ` Roopa Prabhu
2019-05-30 3:17 ` [PATCH iproute2-next 8/9] ip route: Add option to use " David Ahern
2019-05-30 19:59 ` Roopa Prabhu
2019-05-30 3:17 ` [PATCH iproute2-next 9/9] ipmonitor: Add nexthop option to monitor David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30fa885d-67a7-e04d-3f17-07b7cdc599f7@gmail.com \
--to=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).