From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D468C433EF for ; Fri, 24 Sep 2021 09:15:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 473856105A for ; Fri, 24 Sep 2021 09:15:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245226AbhIXJQb (ORCPT ); Fri, 24 Sep 2021 05:16:31 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:63342 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244422AbhIXJQV (ORCPT ); Fri, 24 Sep 2021 05:16:21 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1632474889; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=8s7VVl139a3i809ATKepHde+IYqg4+OOS/K41mjPwTY=; b=t8elIktd4fNKqFnoiCoRxsO0Cuaj5vaT9RJmf33DRVZQnOk6c5Y4YgZ+rlYui8jUvNxkEZQ+ BkYD9Hnu3zNmYQs1AdJNk3GhETpRoDeFpVb+l9G37jl8NpCmwGYW2LBFHo3OBFN/9wBnY5Yh 2/V0JeNHHmd73qDyvFJr2mWjcWg= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyJiZjI2MiIsICJuZXRkZXZAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 614d96c644830700e1b5ee2a (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 24 Sep 2021 09:13:42 GMT Sender: youghand=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id B6A5CC43617; Fri, 24 Sep 2021 09:13:42 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: youghand) by smtp.codeaurora.org (Postfix) with ESMTPSA id 248A1C4338F; Fri, 24 Sep 2021 09:13:42 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Fri, 24 Sep 2021 14:43:42 +0530 From: Youghandhar Chintala To: Johannes Berg Cc: Abhishek Kumar , Felix Fietkau , "David S. Miller" , Jakub Kicinski , linux-wireless , netdev , LKML , Douglas Anderson , Brian Norris , Rakesh Pillai , Manikanta Pubbisetty Subject: Re: [PATCH 2/3] mac80211: Add support to trigger sta disconnect on hardware restart In-Reply-To: <5826123db4731bde01594212101ed5dbbea4d54f.camel@sipsolutions.net> References: <20201215172352.5311-1-youghand@codeaurora.org> (sfid-20210205_225202_513086_43C9BBC9) <66ba0f836dba111b8c7692f78da3f079@codeaurora.org> <5826123db4731bde01594212101ed5dbbea4d54f.camel@sipsolutions.net> Message-ID: <30fa98673ad816ec849f34853c9e1257@codeaurora.org> X-Sender: youghand@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Johannes We thought sending the delba would solve the problem as earlier thought but the actual problem is with TX PN in a secure mode. It is not because of delba that the Seq number and TX PN are reset to zero. It’s because of the HW restart, these parameters are reset to zero. Since FW/HW is the one which decides the TX PN, when it goes through SSR, all these parameters are reset. The other peer say an AP, it does not know anything about the SSR on the peer device. It expects the next TX PN to be current PN + 1. Since TX PN starts from zero after SSR, PN check at AP will fail and it will silently drop all the packets. Regards, Youghandhar On 2021-09-24 13:09, Johannes Berg wrote: > On Fri, 2021-09-24 at 13:07 +0530, Youghandhar Chintala wrote: >> Hi Johannes and felix, >> >> We have tested with DELBA experiment during post SSR, DUT packet seq >> number and tx pn is resetting to 0 as expected but AP(Netgear R8000) >> is >> not honoring the tx pn from DUT. >> Whereas when we tested with DELBA experiment by making Linux android >> device as SAP and DUT as STA with which we don’t see any issue. Ping >> got >> resumed post SSR without disconnect. > > Hm. That's a lot of data, and not a lot of explanation :) > > I don't understand how DelBA and PN are related? > > johannes Regards, Youghandhar -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation