From: David Ahern <dsahern@gmail.com>
To: Ido Schimmel <idosch@mellanox.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, jiri@mellanox.com, mlxsw@mellanox.com
Subject: Re: [PATCH net-next] team: Use extack to report enslavement failures
Date: Tue, 27 Feb 2018 09:37:23 -0700 [thread overview]
Message-ID: <31272e07-a7d6-499d-f1c1-caa2d50e0fb8@gmail.com> (raw)
In-Reply-To: <20180227153808.10740-1-idosch@mellanox.com>
On 2/27/18 8:38 AM, Ido Schimmel wrote:
> Use extack inside team's enslavement function and also propagate it to
> the netdevice notifier to allow enslaved ports to report the failure
> reason. Example:
>
> $ teamd -t team0 -d -c '{"runner": {"name": "lacp"}}'
> $ ip link set dev lo master team0
> Error: Loopback device can't be added as a team port.
>
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
> Acked-by: Jiri Pirko <jiri@mellanox.com>
> ---
> drivers/net/team/team.c | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
LGTM. Acked-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2018-02-27 16:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 15:38 [PATCH net-next] team: Use extack to report enslavement failures Ido Schimmel
2018-02-27 16:37 ` David Ahern [this message]
2018-02-27 19:42 ` Jiri Benc
2018-02-27 20:22 ` Ido Schimmel
2018-02-27 23:49 ` Jakub Kicinski
2018-02-28 7:12 ` Jiri Pirko
2018-02-28 7:21 ` Yuval Mintz
2018-02-28 8:58 ` Jiri Benc
2018-02-28 9:29 ` Jiri Pirko
2018-02-28 14:28 ` David Miller
2018-02-28 16:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31272e07-a7d6-499d-f1c1-caa2d50e0fb8@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).