netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rashika Kheria <rashika.kheria@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Armin Schindler <mac@melware.de>,
	Karsten Keil <isdn@linux-pingi.de>,
	netdev@vger.kernel.org, josh@joshtriplett.org
Subject: [PATCH 17/26] drivers: isdn: Move prototype declaration to header file platform.h from divasi.c
Date: Fri, 7 Feb 2014 18:09:28 +0530	[thread overview]
Message-ID: <315fb0ac18a0c05a74bca047f3e12bbd35a495b7.1390408518.git.rashika.kheria@gmail.com> (raw)
In-Reply-To: <3cb4d7892ba5a0c0936b3a1e2c9c991a6dbc3229.1390408513.git.rashika.kheria@gmail.com>

Move prototype declarations of functions to header file
hardware/eicon/platform.h because they are used by more than one file.

This eliminates the following warnings in hardware/eicon/idifunc.c:
drivers/isdn/hardware/eicon/idifunc.c:243:12: warning: no previous prototype for ‘idifunc_init’ [-Wmissing-prototypes]
drivers/isdn/hardware/eicon/idifunc.c:263:13: warning: no previous prototype for ‘idifunc_finit’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 drivers/isdn/hardware/eicon/divasi.c   |    3 ---
 drivers/isdn/hardware/eicon/platform.h |    3 +++
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/isdn/hardware/eicon/divasi.c b/drivers/isdn/hardware/eicon/divasi.c
index 4103a8c..c2a6f1a 100644
--- a/drivers/isdn/hardware/eicon/divasi.c
+++ b/drivers/isdn/hardware/eicon/divasi.c
@@ -48,9 +48,6 @@ static char *DRIVERLNAME = "diva_idi";
 static char *DEVNAME = "DivasIDI";
 char *DRIVERRELEASE_IDI = "2.0";
 
-extern int idifunc_init(void);
-extern void idifunc_finit(void);
-
 /*
  *  helper functions
  */
diff --git a/drivers/isdn/hardware/eicon/platform.h b/drivers/isdn/hardware/eicon/platform.h
index f170e21..33d6be1 100644
--- a/drivers/isdn/hardware/eicon/platform.h
+++ b/drivers/isdn/hardware/eicon/platform.h
@@ -179,6 +179,9 @@ static __inline__ void diva_os_free(unsigned long flags, void *ptr)
 	vfree(ptr);
 }
 
+int idifunc_init(void);
+void idifunc_finit(void);
+
 /*
 ** use skbuffs for message buffer
 */
-- 
1.7.9.5

  parent reply	other threads:[~2014-02-07 12:39 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-07 12:18 [PATCH 01/26] drivers: isdn: Rectify typing error in xdi_msg.h Rashika Kheria
2014-02-07 12:19 ` [PATCH 02/26] drivers: isdn: Move prototype declaration to header file um_idi.h from um_idi.c Rashika Kheria
2014-02-07 12:20 ` [PATCH 03/26] drivers: isdn: Move prototype declarations to header file um_idi.h from idifunc.c Rashika Kheria
2014-02-07 12:21 ` [PATCH 04/26] drivers: isdn: Add prototype declaration to header file platform.h from capifunc.c Rashika Kheria
2014-02-07 12:24 ` [PATCH 05/26] drivers: isdn: Move prototype declarations to header file capifunc.h from message.c Rashika Kheria
2014-02-07 12:25 ` [PATCH 06/26] drivers: isdn: Move prototype declarations to header file capifunc.h from capifunc.c and message.c Rashika Kheria
2014-02-07 12:26 ` [PATCH 07/26] drivers: isdn: Move prototype declaration to header file platform.h from divasproc.c Rashika Kheria
2014-02-07 12:27 ` [PATCH 08/26] drivers: isdn: Move prototype declaration to header file platform.h from divasmain.c and divasproc.c Rashika Kheria
2014-02-07 12:28 ` [PATCH 09/26] drivers: isdn: Include appropriate header file in diva.c Rashika Kheria
2014-02-07 12:29 ` [PATCH 10/26] drivers: isdn: Move prototype declaration to appropriate header file diva.h Rashika Kheria
2014-02-07 12:33 ` [PATCH 11/26] drivers: isdn: Move prototype declarations to header file platform.h from mntfunc.c Rashika Kheria
2014-02-07 12:34 ` [PATCH 12/26] drivers: isdn: Mark functions as static and remove unused function in hfcmulti.c Rashika Kheria
2014-02-07 12:35 ` [PATCH 13/26] drivers: isdn: Mark functions as static in avmfritz.c Rashika Kheria
2014-02-07 12:36 ` [PATCH 14/26] drivers: isdn: Mark function as static in w6692.c Rashika Kheria
2014-02-07 12:37 ` [PATCH 15/26] drivers: isdn: Mark function as static in mISDNipac.c Rashika Kheria
2014-02-07 12:38 ` [PATCH 16/26] drivers: isdn: Move prototype declarations to appropriate header file hscx.h from elsa_ser.c Rashika Kheria
2014-02-07 12:39 ` Rashika Kheria [this message]
2014-02-07 12:41 ` [PATCH 18/26] drivers: isdn: Mark functions as static in layer2.c Rashika Kheria
2014-02-07 12:42 ` [PATCH 19/26] drivers: isdn: Move prototype declaration to header file platform.h from diva_didd.c Rashika Kheria
2014-02-07 13:33   ` David Laight
2014-02-07 17:15     ` Josh Triplett
2014-02-07 17:22       ` David Laight
2014-02-07 17:41         ` Josh Triplett
2014-02-07 12:43 ` [PATCH 20/26] drivers: isdn: Move prototype declaration to header file platform.h from os_bri.c Rashika Kheria
2014-02-07 12:44 ` [PATCH 21/26] drivers: isdn: Move prototype declaration to header file platform.h from os_4bri.c Rashika Kheria
2014-02-07 12:45 ` [PATCH 22/26] drivers: isdn: Move prototype declaration to header file platform.h from os_pri.c Rashika Kheria
2014-02-07 12:46 ` [PATCH 23/26] drivers: isdn: Move prototype declaration to header file platform.h from divamnt.c Rashika Kheria
2014-02-07 12:47 ` [PATCH 24/26] drivers: isdn: Move prototype declaration to header file hisax.h from config.c Rashika Kheria
2014-02-07 12:48 ` [PATCH 25/26] drivers: isdn: Move prototype declaration to header file dadapter.h Rashika Kheria
2014-02-07 12:49 ` [PATCH 26/26] drivers: isdn: Move prototype declaration to header file platform.h from divasmain.c Rashika Kheria
2014-02-07 18:48 ` [PATCH 01/26] drivers: isdn: Rectify typing error in xdi_msg.h Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=315fb0ac18a0c05a74bca047f3e12bbd35a495b7.1390408518.git.rashika.kheria@gmail.com \
    --to=rashika.kheria@gmail.com \
    --cc=isdn@linux-pingi.de \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mac@melware.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).