From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Colin King <colin.king@canonical.com>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: r6040: add in missing white space in error message text
Date: Mon, 12 Sep 2016 16:04:01 +0300 [thread overview]
Message-ID: <3167d502-bbcc-34db-02d6-8b95ff0a294e@cogentembedded.com> (raw)
In-Reply-To: <20160912120857.31600-1-colin.king@canonical.com>
Hello.
On 9/12/2016 3:08 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> A couple of dev_err messages span two lines and the literal
> string is missing a white space between words. Add the white
> space.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/ethernet/rdc/r6040.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/rdc/r6040.c b/drivers/net/ethernet/rdc/r6040.c
> index cb29ee2..5dc655b 100644
> --- a/drivers/net/ethernet/rdc/r6040.c
> +++ b/drivers/net/ethernet/rdc/r6040.c
> @@ -1062,13 +1062,13 @@ static int r6040_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> /* this should always be supported */
> err = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
> if (err) {
> - dev_err(&pdev->dev, "32-bit PCI DMA addresses"
> + dev_err(&pdev->dev, "32-bit PCI DMA addresses "
> "not supported by the card\n");
> goto err_out_disable_dev;
> }
> err = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));
> if (err) {
> - dev_err(&pdev->dev, "32-bit PCI DMA addresses"
> + dev_err(&pdev->dev, "32-bit PCI DMA addresses "
> "not supported by the card\n");
> goto err_out_disable_dev;
> }
The message strings simply shouldn't be broken up, and checkpatch.pl knows
about that.
MBR, Sergei
prev parent reply other threads:[~2016-09-12 13:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 12:08 [PATCH] net: r6040: add in missing white space in error message text Colin King
2016-09-12 13:04 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3167d502-bbcc-34db-02d6-8b95ff0a294e@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=colin.king@canonical.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox