Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Gautam Ramakrishnan <gautamramk@gmail.com>, netdev@vger.kernel.org
Cc: jhs@mojatatu.com, davem@davemloft.net, xiyou.wangcong@gmail.com,
	Leslie Monis <lesliemonis@gmail.com>,
	"Mohit P . Tahiliani" <tahiliani@nitk.edu.in>,
	Dave Taht <dave.taht@gmail.com>
Subject: Re: [net-next] net: sched: pie: enable timestamp based delay calculation
Date: Tue, 27 Aug 2019 17:34:51 +0200	[thread overview]
Message-ID: <316fdac3-5fa9-35d5-ad74-94072f19c5fc@gmail.com> (raw)
In-Reply-To: <20190827141938.23483-1-gautamramk@gmail.com>



On 8/27/19 4:19 PM, Gautam Ramakrishnan wrote:
> RFC 8033 suggests an alternative approach to calculate the queue
> delay in PIE by using per packet timestamps. This patch enables the
> PIE implementation to do this.
> 
> The calculation of queue delay is as follows:
> 	qdelay = now - packet_enqueue_time
> 
> To enable the use of timestamps:
> 	modprobe sch_pie use_timestamps=1


No module parameter is accepted these days.

Please add a new attribute instead,
so that pie can be used in both mode on the same host.

For a typical example of attribute addition, please take
a look at commit 48872c11b77271ef9b070bdc50afe6655c4eb9aa
("net_sched: sch_fq: add dctcp-like marking")

  reply	other threads:[~2019-08-27 15:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-27 14:19 [net-next] net: sched: pie: enable timestamp based delay calculation Gautam Ramakrishnan
2019-08-27 15:34 ` Eric Dumazet [this message]
2019-08-27 16:58   ` Dave Taht
2019-08-29  7:21     ` Gautam Ramakrishnan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=316fdac3-5fa9-35d5-ad74-94072f19c5fc@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=dave.taht@gmail.com \
    --cc=davem@davemloft.net \
    --cc=gautamramk@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=lesliemonis@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=tahiliani@nitk.edu.in \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox