From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1B4BC433E0 for ; Sat, 23 Jan 2021 00:01:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75E0323B53 for ; Sat, 23 Jan 2021 00:01:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726361AbhAWAAw (ORCPT ); Fri, 22 Jan 2021 19:00:52 -0500 Received: from 95-165-96-9.static.spd-mgts.ru ([95.165.96.9]:44190 "EHLO blackbox.su" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1726564AbhAVX7h (ORCPT ); Fri, 22 Jan 2021 18:59:37 -0500 Received: from metabook.localnet (metabook.metanet [192.168.2.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by blackbox.su (Postfix) with ESMTPSA id C058382100; Sat, 23 Jan 2021 02:59:04 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blackbox.su; s=mail; t=1611359944; bh=g6BvVahX0EV1gqwZyMX/H/ev/xf2JWjDorAxoSJhcnU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CsnKEMH5XFcIgO4Li/k0bPVcBUcLUGtJ1uhOCtVTIbVWeIk/km8Fn2vXkpYLsan65 SKOUT4Jmp9z2XNidRWHowWMJ2JviY02DhO0w+Wyxeo4b7oKrH+V40chLnU41ljeK7f RtloBuOJebPGcdRnppohkEX1Zrqm8EuabScqvSqyIBjYeeadmd9EMVogrgi5+7al0N uuxa/FpuehAanKOFNyExwT9IOzuUjTsv2MB74Sa8IzNZe7qPXwoh9cURe+CxKq0ers 9HhYPyJqYvFUR8mSAJfE7UBLQwanq1xGrOIKM49syWM6GTl0jCB17bM5Q3BuJ9h5Or Kh0TnI8JKabug== From: Sergej Bauer To: Andrew Lunn Cc: netdev@vger.kernel.org, f.fainelli@gmail.com, "David S. Miller" , Jakub Kicinski , Bryan Whitehead , UNGLinuxDriver@microchip.com, Simon Horman , Mark Einon , Madalin Bucur , Arnd Bergmann , Masahiro Yamada , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices Date: Sat, 23 Jan 2021 02:58:12 +0300 Message-ID: <3174210.ndmClRx9B8@metabook> In-Reply-To: References: <20210122214247.6536-1-sbauer@blackbox.su> <21783568.4JFRnjC3Rk@metabook> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Saturday, January 23, 2021 2:23:25 AM MSK Andrew Lunn wrote: > > > > @@ -1000,8 +1005,10 @@ static void lan743x_phy_close(struct > > > > lan743x_adapter *adapter)> > > > > > > > > struct net_device *netdev = adapter->netdev; > > > > > > > > phy_stop(netdev->phydev); > > > > > > > > - phy_disconnect(netdev->phydev); > > > > - netdev->phydev = NULL; > > > > + if (phy_is_pseudo_fixed_link(netdev->phydev)) > > > > + lan743x_virtual_phy_disconnect(netdev->phydev); > > > > + else > > > > + phy_disconnect(netdev->phydev); > > > > > > phy_disconnect() should work. You might want to call > > There are drivers which call phy_disconnect() on a fixed_link. e.g. > > https://elixir.bootlin.com/linux/v5.11-rc4/source/drivers/net/usb/lan78xx.c# > L3555. > > It could be your missing call to fixed_phy_unregister() is leaving > behind bad state. > lan743x_virtual_phy_disconnect removes sysfs-links and calls fixed_phy_unregister() and the reason was phydev in sysfs. > > It was to make ethtool show full set of supported speeds and MII only in > > supported ports (without TP and the no any ports in the bare card). > > But fixed link does not support the full set of speed. It is fixed. It > supports only one speed it is configured with. That's why I "re-implemented the fixed PHY driver" as Florian said. The goal of virtual phy was to make an illusion of real device working in loopback mode. So I could use ethtool and ioctl's to switch speed of device. > And by setting it > wrongly, you are going to allow the user to do odd things, like use > ethtool force the link speed to a speed which is not actually > supported. I have lan743x only and in loopback mode it allows to use speeds 10/100/1000MBps in full-duplex mode only. But the highest speed I have achived was something near 752Mbps... And I can switch speed on the fly, without reloading the module. May by I should limit the list of acceptable devices? > > Andrew