From: Marcel Holtmann <marcel@holtmann.org>
To: Kangmin Park <l4stpr0gr4m@gmail.com>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Tedd Ho-Jeong An <tedd.an@intel.com>,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] Bluetooth: Fix return value in hci_dev_do_close()
Date: Thu, 19 Aug 2021 17:29:15 +0200 [thread overview]
Message-ID: <31F9AB85-09D2-4EC0-B054-FD4EEF8CEEE4@holtmann.org> (raw)
In-Reply-To: <20210819152718.2713-1-l4stpr0gr4m@gmail.com>
Hi Kangmin,
> hci_error_reset() return without calling hci_dev_do_open() when
> hci_dev_do_close() return error value which is not 0.
>
> Also, hci_dev_close() return hci_dev_do_close() function's return
> value.
>
> But, hci_dev_do_close() return always 0 even if hdev->shutdown
> return error value. So, fix hci_dev_do_close() to save and return
> the return value of the hdev->shutdown when it is called.
>
> Signed-off-by: Kangmin Park <l4stpr0gr4m@gmail.com>
> ---
> Changes in v4:
> - rename variable to err.
>
> net/bluetooth/hci_core.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
prev parent reply other threads:[~2021-08-19 15:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 15:27 [PATCH v4] Bluetooth: Fix return value in hci_dev_do_close() Kangmin Park
2021-08-19 15:29 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31F9AB85-09D2-4EC0-B054-FD4EEF8CEEE4@holtmann.org \
--to=marcel@holtmann.org \
--cc=davem@davemloft.net \
--cc=johan.hedberg@gmail.com \
--cc=kuba@kernel.org \
--cc=l4stpr0gr4m@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tedd.an@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox