From: George Shuklin <george.shuklin@gmail.com>
To: Pavan Chebbi <pavan.chebbi@broadcom.com>
Cc: netdev@vger.kernel.org,
Andrew Gospodarek <andrew.gospodarek@broadcom.com>,
Michael Chan <michael.chan@broadcom.com>
Subject: Re: [PATCH] [PATCH net] tg3: power down device only on SYSTEM_POWER_OFF
Date: Wed, 1 Nov 2023 21:58:08 +0200 [thread overview]
Message-ID: <31a5cfe8-133d-4548-9814-cf3e61d89307@gmail.com> (raw)
In-Reply-To: <CALs4sv37sniGKkYADvHwwMjFzp5tBbBnpfOnyK-peM=rnp63Bw@mail.gmail.com>
On 01/11/2023 17:20, Pavan Chebbi wrote:
> On Wed, Nov 1, 2023 at 6:34 PM George Shuklin <george.shuklin@gmail.com> wrote:
>> Dell R650xs servers hangs if tg3 driver calls tg3_power_down.
>>
>> This happens only if network adapters (BCM5720 for R650xs) were
>> initialized using SNP (e.g. by booting ipxe.efi).
>>
>> This is partial revert of commit 2ca1c94ce0b.
>>
>> The actual problem is on Dell side, but this fix allow servers
>> to come back alive after reboot.
> How are you sure that the problem solved by 2ca1c94ce0b is not
> reintroduced with this change?
I contacted the author of original patch, no reply yet (1st day). Also,
I tested it on few generations of available Dell servers (R330, R340,
R350 and R650sx, for which this fix should help). It does produce log
message from
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1917471, but, at
least, it reboots without issues.
Actually, original patch is regression: 5.19 rebooting just fine, 6.0
start to hang. I also reported it to dell support forum, but I'm not
sure if they pick it up or not.
What would be the proper course of actions for such problem (outside of
fixing UEFI SNP, for which I don't have access to sources)?
next prev parent reply other threads:[~2023-11-01 19:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 13:04 [PATCH] [PATCH net] tg3: power down device only on SYSTEM_POWER_OFF George Shuklin
2023-11-01 15:20 ` Pavan Chebbi
2023-11-01 19:58 ` George Shuklin [this message]
2023-11-02 7:04 ` Pavan Chebbi
2023-11-02 14:14 ` George Shuklin
2023-11-02 17:11 ` Pavan Chebbi
2023-11-02 17:49 ` Michael Chan
2023-11-03 3:48 ` Pavan Chebbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31a5cfe8-133d-4548-9814-cf3e61d89307@gmail.com \
--to=george.shuklin@gmail.com \
--cc=andrew.gospodarek@broadcom.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pavan.chebbi@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox