From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5004C4363D for ; Fri, 2 Oct 2020 06:30:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8BCE2206E3 for ; Fri, 2 Oct 2020 06:30:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726090AbgJBGa4 (ORCPT ); Fri, 2 Oct 2020 02:30:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725968AbgJBGaz (ORCPT ); Fri, 2 Oct 2020 02:30:55 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C83BEC0613D0 for ; Thu, 1 Oct 2020 23:30:55 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1kOEaf-00F5T7-0j; Fri, 02 Oct 2020 08:30:49 +0200 Message-ID: <31b9f6c154d853e3755cb0f90005945ef43c82ad.camel@sipsolutions.net> Subject: Re: [PATCH net-next v2 08/10] genetlink: use parsed attrs in dumppolicy From: Johannes Berg To: Jakub Kicinski , davem@davemloft.net Cc: netdev@vger.kernel.org, andrew@lunn.ch, jiri@resnulli.us, mkubecek@suse.cz, dsahern@kernel.org, pablo@netfilter.org Date: Fri, 02 Oct 2020 08:30:47 +0200 In-Reply-To: <20201001225933.1373426-9-kuba@kernel.org> References: <20201001225933.1373426-1-kuba@kernel.org> <20201001225933.1373426-9-kuba@kernel.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 2020-10-01 at 15:59 -0700, Jakub Kicinski wrote: > Attributes are already parsed based on the policy specified > in the family and ready-to-use in info->attrs. No need to > call genlmsg_parse() again. :) Reviewed-by: Johannes Berg johannes