From: "Felipe Balbi" <felipebalbi@users.sourceforge.net>
To: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>
Cc: "Emil Medve" <Emilian.Medve@freescale.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
i2c@lm-sensors.org, linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH v2] Move the definition of pr_err() into kernel.h
Date: Tue, 11 Sep 2007 15:56:33 -0400 [thread overview]
Message-ID: <31e679430709111256o212be3e4tcefb6decf2e136e0@mail.gmail.com> (raw)
In-Reply-To: <D5C1322C3E673F459512FB59E0DDC32903925779@orsmsx414.amr.corp.intel.com>
Hi,
On 9/11/07, Waskiewicz Jr, Peter P <peter.p.waskiewicz.jr@intel.com> wrote:
<snip>
> > -#define pr_err(fmt, arg...) printk(KERN_ERR DRIVER_NAME ":
> > ", ## arg);
> > -
>
> Unnecessary whitespace removal.
Actually... I prefer removing the extra blank-line... it's easier to
read and keeps on blank-line only to separate other
defines/code-portion
Same to all the others
<snip><snip><snip><snip><snip>
--
Best Regards,
Felipe Balbi
felipebalbi@users.sourceforge.net
prev parent reply other threads:[~2007-09-11 19:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-11 18:13 [PATCH v2] Move the definition of pr_err() into kernel.h Emil Medve
2007-09-11 19:48 ` Waskiewicz Jr, Peter P
2007-09-11 19:56 ` Medve Emilian-EMMEDVE1
2007-09-11 19:56 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31e679430709111256o212be3e4tcefb6decf2e136e0@mail.gmail.com \
--to=felipebalbi@users.sourceforge.net \
--cc=Emilian.Medve@freescale.com \
--cc=i2c@lm-sensors.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap-open-source@linux.omap.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox