From: Florian Fainelli <f.fainelli@gmail.com>
To: Russell King <rmk+kernel@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Andy Fleming <afleming@freescale.com>,
David Woodhouse <dwmw2@infradead.org>,
Ben Hutchings <ben@decadent.org.uk>
Subject: Re: [PATCH net v2] mod_devicetable: fix PHY module format
Date: Thu, 19 Dec 2019 19:57:29 -0800 [thread overview]
Message-ID: <31fc357c-2e50-beaf-5a88-4e6dac40d7ad@gmail.com> (raw)
In-Reply-To: <E1ii59z-0003Na-Rb@rmk-PC.armlinux.org.uk>
On 12/19/2019 3:24 PM, Russell King wrote:
> When a PHY is probed, if the top bit is set, we end up requesting a
> module with the string "mdio:-10101110000000100101000101010001" -
> the top bit is printed to a signed -1 value. This leads to the module
> not being loaded.
>
> Fix the module format string and the macro generating the values for
> it to ensure that we only print unsigned types and the top bit is
> always 0/1. We correctly end up with
> "mdio:10101110000000100101000101010001".
>
> Fixes: 8626d3b43280 ("phylib: Support phy module autoloading")
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2019-12-20 3:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 23:24 [PATCH net v2] mod_devicetable: fix PHY module format Russell King
2019-12-20 3:57 ` Florian Fainelli [this message]
2019-12-21 5:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31fc357c-2e50-beaf-5a88-4e6dac40d7ad@gmail.com \
--to=f.fainelli@gmail.com \
--cc=afleming@freescale.com \
--cc=andrew@lunn.ch \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).