From: Jay Vosburgh <fubar@us.ibm.com>
To: Veaceslav Falico <vfalico@redhat.com>
Cc: netdev@vger.kernel.org, Andy Gospodarek <andy@greyhouse.net>
Subject: Re: [PATCH v2 net-next 05/12] bonding: extend arp_validate to be able to receive unvalidated arp-only traffic
Date: Fri, 17 Jan 2014 12:41:29 -0800 [thread overview]
Message-ID: <32086.1389991289@death.nxdomain> (raw)
In-Reply-To: <1389977940-17084-6-git-send-email-vfalico@redhat.com>
Veaceslav Falico <vfalico@redhat.com> wrote:
>Currently we can either receive any traffic as a proff of slave being up,
>or only *validated* arp traffic (i.e. with src/dst ip checked).
>
>Add an option to be able to specify if we want to receive non-validated arp
>traffic only.
>
>CC: Jay Vosburgh <fubar@us.ibm.com>
>CC: Andy Gospodarek <andy@greyhouse.net>
>Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
>---
> drivers/net/bonding/bond_main.c | 3 +++
> drivers/net/bonding/bonding.h | 11 +++++++++++
> 2 files changed, 14 insertions(+)
>
>diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>index 07ae82d..532a452 100644
>--- a/drivers/net/bonding/bond_main.c
>+++ b/drivers/net/bonding/bond_main.c
>@@ -246,6 +246,9 @@ const struct bond_parm_tbl arp_validate_tbl[] = {
> { "active", BOND_ARP_VALIDATE_ACTIVE},
> { "backup", BOND_ARP_VALIDATE_BACKUP},
> { "all", BOND_ARP_VALIDATE_ALL},
>+{ "arp", BOND_ARP_VALIDATE_ARP},
>+{ "active_arp", BOND_ARP_VALIDATE_ACTIVE_ARP},
>+{ "backup_arp", BOND_ARP_VALIDATE_BACKUP_ARP},
> { NULL, -1},
> };
>
>diff --git a/drivers/net/bonding/bonding.h b/drivers/net/bonding/bonding.h
>index 955dc48..1fbbf04 100644
>--- a/drivers/net/bonding/bonding.h
>+++ b/drivers/net/bonding/bonding.h
>@@ -318,6 +318,11 @@ static inline bool bond_is_active_slave(struct slave *slave)
> #define BOND_ARP_VALIDATE_BACKUP (1 << BOND_STATE_BACKUP)
> #define BOND_ARP_VALIDATE_ALL (BOND_ARP_VALIDATE_ACTIVE | \
> BOND_ARP_VALIDATE_BACKUP)
>+#define BOND_ARP_VALIDATE_ARP (BOND_ARP_VALIDATE_ALL + 1)
>+#define BOND_ARP_VALIDATE_ACTIVE_ARP (BOND_ARP_VALIDATE_ACTIVE | \
>+ BOND_ARP_VALIDATE_ARP)
>+#define BOND_ARP_VALIDATE_BACKUP_ARP (BOND_ARP_VALIDATE_BACKUP | \
>+ BOND_ARP_VALIDATE_ARP)
If you go with my suggestion to call the new thing "filtering,"
I'd change these option names, labels, and the function
"slave_do_arp_validate_only" names. The function name seems kind of
confusing in particular. I think it'd be clearer to replace the
"validate" stuff with "filter."
-J
> static inline int slave_do_arp_validate(struct bonding *bond,
> struct slave *slave)
>@@ -325,6 +330,12 @@ static inline int slave_do_arp_validate(struct bonding *bond,
> return bond->params.arp_validate & (1 << bond_slave_state(slave));
> }
>
>+static inline int slave_do_arp_validate_only(struct bonding *bond,
>+ struct slave *slave)
>+{
>+ return bond->params.arp_validate & BOND_ARP_VALIDATE_ARP;
>+}
>+
> /* Get the oldest arp which we've received on this slave for bond's
> * arp_targets.
> */
>--
>1.8.4
>
---
-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com
next prev parent reply other threads:[~2014-01-17 20:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 16:58 [PATCH v2 net-next 0/12] bonding: add an option to rely on unvalidated arp packets Veaceslav Falico
2014-01-17 16:58 ` [PATCH v2 net-next 01/12] bonding: remove bond->lock from bond_arp_rcv Veaceslav Falico
2014-01-17 16:58 ` [PATCH v2 net-next 02/12] bonding: permit using arp_validate with non-ab modes Veaceslav Falico
2014-01-17 16:58 ` [PATCH v2 net-next 03/12] bonding: always update last_arp_rx on packet recieve Veaceslav Falico
2014-01-17 16:58 ` [PATCH v2 net-next 04/12] bonding: always set recv_probe to bond_arp_rcv in arp monitor Veaceslav Falico
2014-01-17 16:58 ` [PATCH v2 net-next 05/12] bonding: extend arp_validate to be able to receive unvalidated arp-only traffic Veaceslav Falico
2014-01-17 20:41 ` Jay Vosburgh [this message]
2014-01-23 10:25 ` Veaceslav Falico
2014-01-17 16:58 ` [PATCH v2 net-next 06/12] bonding: document the new _arp options for arp_validate Veaceslav Falico
2014-01-17 20:38 ` Jay Vosburgh
2014-02-17 13:36 ` Veaceslav Falico
2014-01-17 16:58 ` [PATCH v2 net-next 07/12] bonding: use the new options to correctly set last_arp_rx Veaceslav Falico
2014-01-17 20:32 ` Neil Horman
2014-01-17 16:58 ` [PATCH v2 net-next 08/12] bonding: use last_arp_rx in slave_last_rx() Veaceslav Falico
2014-01-17 16:58 ` [PATCH v2 net-next 09/12] bonding: use last_arp_rx in bond_loadbalance_arp_mon() Veaceslav Falico
2014-01-17 16:58 ` [PATCH v2 net-next 10/12] bonding: remove useless updating of slave->dev->last_rx Veaceslav Falico
2014-01-17 16:58 ` [PATCH v2 net-next 11/12] bonding: trivial: rename slave->jiffies to ->last_link_up Veaceslav Falico
2014-01-17 16:59 ` [PATCH v2 net-next 12/12] bonding: rename last_arp_rx to last_rx Veaceslav Falico
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32086.1389991289@death.nxdomain \
--to=fubar@us.ibm.com \
--cc=andy@greyhouse.net \
--cc=netdev@vger.kernel.org \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).