Re: [tcpdump-workers] [PATCH net 1/2] net: dev_queue_xmit_nit: fix skb->vlan_tci field value

[Michael Richardson <mcr@sandelman.ca>]

[-- Attachment #1: Type: text/plain, Size: 1549 bytes --]


>>>>> "Eric" == Eric Dumazet <eric.dumazet@gmail.com> writes:
    Eric> On Wed, 2013-01-09 at 11:27 -0800, Ani Sinha wrote:

    >> This is wrong. Accelerated or not, the kernel code was organized to
    >> have the tags in the packet aux data. So I think this is how user land
    >> should be coded as well.

    Eric> You have your opinion, thats good.

    Eric> My opinion as a kernel developer is that the network tap is here to have
    Eric> a copy of the exact frame given to the _device_.

Good: as someone who spends lots of time with tcpdump doing both network
and protocol diagnostics, it's really important to see exactly there.
If that means turning off some hardware offload in order to get the
intact 1p header, then that may be fine for many situations.
(At 10G, on a live router... well...)

The problem is that now we need to know, on a per device basis (based
upon the current configuration) if the VLAN tag was removed by the
hardware or not.  It's not enough to try with vlan tag and not.

    Eric> If you want other taps, and catch frames before/after various netfilter
    Eric> hooks, segmentations, vlan accel, tunnels, or before GRO layer, thats a
    Eric> totally different request.

Yes!!!! We need all of these tap points too... 

-- 
]               Never tell me the odds!                 | ipv6 mesh networks [ 
]   Michael Richardson, Sandelman Software Works        | network architect  [ 
]     mcr@sandelman.ca  http://www.sandelman.ca/        |   ruby on rails    [ 
	



[-- Attachment #2: Type: application/pgp-signature, Size: 307 bytes --]