From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiner Kallweit Subject: [PATCH net-next 2/2] r8169: enable ASPM on RTL8168E-VL Date: Sat, 23 Jun 2018 09:53:00 +0200 Message-ID: <321584c6-a739-7d2c-0af5-42463d3577d1@gmail.com> References: <50617290-b86c-f5fd-5d74-87459b0e9a4d@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "netdev@vger.kernel.org" To: Realtek linux nic maintainers , David Miller Return-path: Received: from mail-wr0-f193.google.com ([209.85.128.193]:46327 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751599AbeFWHxP (ORCPT ); Sat, 23 Jun 2018 03:53:15 -0400 Received: by mail-wr0-f193.google.com with SMTP id l14-v6so3654000wrq.13 for ; Sat, 23 Jun 2018 00:53:14 -0700 (PDT) In-Reply-To: <50617290-b86c-f5fd-5d74-87459b0e9a4d@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Let's enable ASPM also on the RTL8168E-VL (chip version 34). Works fine on my Zotac Mini PC with this chip. Temperature when being idle is significantly lower than before due to reaching deeper PC states. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index d5e380d9..44715958 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -5541,6 +5541,8 @@ static void rtl_hw_start_8168e_2(struct rtl8169_private *tp) RTL_W8(tp, DLLPR, RTL_R8(tp, DLLPR) | PFM_EN); RTL_W32(tp, MISC, RTL_R32(tp, MISC) | PWM_EN); RTL_W8(tp, Config5, RTL_R8(tp, Config5) & ~Spi_en); + + rtl_hw_aspm_clkreq_enable(tp, true); } static void rtl_hw_start_8168f(struct rtl8169_private *tp) -- 2.18.0